Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tiff] unused CMake variable CMAKE_DEBUG_POSTFIX #19602

Closed
Be-ing opened this issue Aug 16, 2021 · 3 comments
Closed

[tiff] unused CMake variable CMAKE_DEBUG_POSTFIX #19602

Be-ing opened this issue Aug 16, 2021 · 3 comments
Assignees
Labels
category:question This issue is a question

Comments

@Be-ing
Copy link
Contributor

Be-ing commented Aug 16, 2021

Host Environment

  • OS: x64-linux (Fedora 34)
  • Compiler: GCC 11.2.1

To Reproduce
Steps to reproduce the behavior:
./vcpkg install tiff

Failure logs

Building package tiff[core,jpeg,lzma,zip]:x64-linux...
-- Downloading https://download.osgeo.org/libtiff/tiff-4.3.0.tar.gz -> tiff-4.3.0.tar.gz...
-- Extracting source /home/be/sw/vcpkg/downloads/tiff-4.3.0.tar.gz
-- Applying patch cmakelists.patch
-- Applying patch fix-pkgconfig.patch
-- Applying patch FindCMath.patch
-- Using source at /home/be/sw/vcpkg/buildtrees/tiff/src/4.3.0-84bf77f2fa.clean
-- Found external ninja('1.10.2').
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
CMake Warning at /home/be/sw/tenacity/build/vcpkg_installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:472 (message):
  The following variables are not used in CMakeLists.txt:

      CMAKE_DEBUG_POSTFIX

  Please recheck them and remove the unnecessary options from the
  `vcpkg_cmake_configure` call.

  If these options should still be passed for whatever reason, please use the
  `MAYBE_UNUSED_VARIABLES` argument.
Call Stack (most recent call first):
  ports/tiff/portfile.cmake:42 (vcpkg_cmake_configure)
  scripts/ports.cmake:141 (include)
@dg0yt
Copy link
Contributor

dg0yt commented Aug 16, 2021

Please stop opening issues for "unused variables". It is not a failure. It is a new check to support maintainers, to be handled when making changes to a port.
And last not least, CMAKE_DEBUG_POSTFIX is a false positive.

@JackBoosY
Copy link
Contributor

All the variables have prefix CMAKE_ should be ignored.

@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Aug 17, 2021
@LilyWangLL LilyWangLL assigned JonLiu1993 and unassigned JackBoosY Dec 6, 2022
@JonLiu1993 JonLiu1993 added category:question This issue is a question and removed category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Apr 26, 2023
@JonLiu1993
Copy link
Member

Fixed by PR #23864.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:question This issue is a question
Projects
None yet
Development

No branches or pull requests

4 participants