Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading message about exported nupkg file name #18543

Open
GreyCat opened this issue Jun 18, 2021 · 1 comment
Open

Misleading message about exported nupkg file name #18543

GreyCat opened this issue Jun 18, 2021 · 1 comment
Assignees
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)

Comments

@GreyCat
Copy link
Member

GreyCat commented Jun 18, 2021

Describe the bug

When attempting to do vcpkg export with overriding a --nuget-version with something shorter than 3 dot-separated numbers (as per semver standard), vcpkg silently fixes that to match "X.Y.Z" semver schema by adding zeroes, and then shows a very misleading message about a file generated, which uses whatever a user has passed on the command line rather than what vcpkg used in reality while writing a file.

Environment

  • OS: Windows
  • Compiler: MSVC 2019

To Reproduce
Steps to reproduce the behavior:

  1. Run ./vcpkg export gtest --nuget --nuget-id=gtest --nuget-version=1.2
  2. vcpkg reports this:
    NuGet package exported at: X:\vcpkg\gtest.1.2.nupkg
    
  3. However, in reality, exported file is found in X:\vcpkg\gtest.1.2.0.nupkg, not X:\vcpkg\gtest.1.2.nupkg.

Expected behavior

vcpkg message should report correct file name, matching what it exports.

@PhoebeHui PhoebeHui added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Jun 21, 2021
@PhoebeHui
Copy link
Contributor

@GreyCat, thanks for reporting this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Development

No branches or pull requests

2 participants