Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glslang] Update to 11.1.0 #16305

Closed
axsaucedo opened this issue Feb 19, 2021 · 5 comments
Closed

[glslang] Update to 11.1.0 #16305

axsaucedo opened this issue Feb 19, 2021 · 5 comments
Assignees
Labels
category:port-update The issue is with a library, which is requesting update new revision

Comments

@axsaucedo
Copy link

Describe the bug
Currently the KhrosnoGroup/glslang seems to have released a build that does not seem to align with the current official tags of the repository https://github.com/KhronosGroup/glslang - example would include official versions such as 11.1.0, 11.0.0, etc.

Environment

  • OS: All OS
  • Compiler: revision

To Reproduce
Install any package of glslang

Expected behavior
The stable tags being used instead

Failure logs
N/A

Additional context
N/A

@JonLiu1993 JonLiu1993 assigned JackBoosY and NancyLi1013 and unassigned JackBoosY Feb 20, 2021
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Feb 20, 2021
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Feb 20, 2021

Hi @axsaucedo

Thanks for posting this issue.

I think you mean we should update glslang to a stable version, such as 11.0.0 or 11.1.0 instead of stable branch.

@axsaucedo axsaucedo changed the title KhronosGroup/glslang using master instead of stable branches KhronosGroup/glslang using stable branches instead of master Feb 20, 2021
@axsaucedo
Copy link
Author

Oh thank you for the heads up - it seems I had the title wrong, but the description does outline the correct points, yes it would be to update glslang to a stable version. The main reason is also because the Include locations differ quite significantly between 11.1 and master, so there are too many breaking changes for it to be the main one to use.

I have also opened an issue in KhronosGroup/glslang confirming that 11.1.0 is the correct version to use KhronosGroup/glslang#2539

@NancyLi1013
Copy link
Contributor

Thanks for your clarification. I will try to update it to the latest stable version and check if it can work fine.

@NancyLi1013 NancyLi1013 changed the title KhronosGroup/glslang using stable branches instead of master [glslang] Update to 11.1.0 Feb 22, 2021
@axsaucedo
Copy link
Author

Great, thank you @NancyLi1013, let me know once successful and I can also confirm that it works as expected as I have a project that currently integrates with glslang 11.1.0

@NancyLi1013
Copy link
Contributor

@axsaucedo

I noticed that there was another issue #15498 that requested to update glslang to 11.1.0.

So let's track this issue there. The related PR #15719.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

No branches or pull requests

3 participants