-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[glslang] Update to 11.1.0 #16305
Comments
Hi @axsaucedo Thanks for posting this issue. I think you mean we should update |
Oh thank you for the heads up - it seems I had the title wrong, but the description does outline the correct points, yes it would be to update glslang to a stable version. The main reason is also because the Include locations differ quite significantly between 11.1 and master, so there are too many breaking changes for it to be the main one to use. I have also opened an issue in KhronosGroup/glslang confirming that 11.1.0 is the correct version to use KhronosGroup/glslang#2539 |
Thanks for your clarification. I will try to update it to the latest stable version and check if it can work fine. |
Great, thank you @NancyLi1013, let me know once successful and I can also confirm that it works as expected as I have a project that currently integrates with glslang 11.1.0 |
Describe the bug
Currently the KhrosnoGroup/glslang seems to have released a build that does not seem to align with the current official tags of the repository https://github.com/KhronosGroup/glslang - example would include official versions such as
11.1.0
,11.0.0
, etc.Environment
To Reproduce
Install any package of glslang
Expected behavior
The stable tags being used instead
Failure logs
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: