-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[x264:x86-windows] build failure #11765
Comments
By the way, I notice the error message says it is trying to use D:/source/test/vcpkg/downloads/tools/msys2/msys64/usr/share/automake-1.16
|
Confirmed. That's a |
After some investigations I've found that the This bring a wrong environment detection, and it thinks it is GNU while it should be MS. Even fixing the configure file by hand leads to some LINK 1189 issues which I can't yet figure out why they are showing up. I'll update this issue as soon as I figure out what's the issue... //EDIT1: So yes, I do agree the issue is //EDIT2: So, I found the core issue living in here but I'm not sure which is the correct patch to solve it. Long story short, the main issue is linked between:
So, to solve it, I patched the CC/CCX flags by removing the Be aware that the current way CC/CCX flags are being set also trigger a false GNU detection by most of the scripts you build out of make. So I think it's just wise to remove the automake compile script path before I can submit a PR if you're interested. Just let me know in case. //EDIT3: It seems this approach works fine when running //EDIT4: Managed to get it fixed for AppVeyor too! Here you can find the project where I have all the patched files accordingly: https://github.com/julianxhokaxhiu/ffmpegCI ( I even bumped both ffmpeg and x264 library branches, so don't mind that part ) |
I think it's better to summon the author of that change first, as he has done tremendous work improving/correcting make builds, there has to be a reason why call to @Neumann-A, could you, please, comment on this issue? |
If a port is truly using autotools there should not be a problem with routing it through automakes |
config-x86-windows-...-out.log
build-x86-windows-...-err.log
flags gcc ? |
So If I understand this correctly, all we need to do is redefine CC and CXX? I'll try that and let you know! |
Is the error I see in #11836 (only in x86-windows) |
So how is it going? I still cannot install neither |
I am hitting this as well. Happy to help testing fixes. |
got this after the patches: C:\vcpackage\vcpkg>vcpkg install ffmpeg[ffmpeg,x264]:x64-windows
Error: Building package x264:x64-windows failed with: BUILD_FAILED Additionally, attach any relevant sections from the log files above. |
@samofoz I'm currently using this patchset now https://github.com/julianxhokaxhiu/ffmpegCI/tree/master/patch That post is "more or less" outdated now. |
Same problem with these patches: C:\vcpackage\vcpkg>vcpkg install ffmpeg[ffmpeg,x264]:x64-windows --recurse
Error: Building package x264:x64-windows failed with: BUILD_FAILED Additionally, attach any relevant sections from the log files above. |
You can't just update the x264 patch, you need also the one in |
Hi Julian, I did copy both the patches. Check the logs carefully - the library is being compiled fine but the error seems to be during installation: Library "x264" was not found! If it is a system library use the |
I see, I'm personally building using |
New issue with latest vcpkg: ffmpeg[ffmpeg,x264] installation fails with "libx264 not found": C:\vcpackage\vcpkg>vcpkg install ffmpeg[ffmpeg,x264]:x64-windows
Call Stack (most recent call first): Error: Building package ffmpeg:x64-windows failed with: BUILD_FAILED Additionally, attach any relevant sections from the log files above. |
@samofoz, I would advice openning a new issue -- comments in the closed issues sometimes are being ignored. |
Host Environment
To Reproduce
Steps to reproduce the behavior:
./vcpkg install x264
Failure logs
config-x86-windows-dbg-out.log
The text was updated successfully, but these errors were encountered: