Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libarchive] Missing ZSTD linkage in wrapper for dependent ports #11002

Closed
Neumann-A opened this issue Apr 24, 2020 · 0 comments · Fixed by #11044
Closed

[libarchive] Missing ZSTD linkage in wrapper for dependent ports #11002

Neumann-A opened this issue Apr 24, 2020 · 0 comments · Fixed by #11044
Assignees
@JackBoosY
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@Neumann-A
Copy link
Contributor

Neumann-A commented Apr 24, 2020 •
edited
Loading

Failure logs
shortened log:

archive.lib(archive_write_add_filter_zstd.c.obj) : error LNK2019: unresolved external symbol ZSTD_isError referenced in function archive_compressor_zstd_open
archive.lib(archive_read_support_filter_zstd.c.obj) : error LNK2001: unresolved external symbol ZSTD_isError
archive.lib(archive_write_add_filter_zstd.c.obj) : error LNK2019: unresolved external symbol ZSTD_getErrorName referenced in function drive_compressor

Additional context
Dependency not correctly handled by port. There seems to be an ENABLE_ZSTD option which is not exposed in the portfile (only checked the fix-zstd.patch for that conclusion -> TODO check CMakeLists.txt).
Reason for build failure in #10770 (x64-windows-static) https://dev.azure.com/vcpkg/public/_build/results?buildId=34965&view=logs&j=e1398d9f-ede2-5462-d45c-fe1632336682&t=8673dc57-1f38-5bfb-1f77-5a72c5f983aa&l=21
@Neumann-A Neumann-A added the category:port-bug The issue is with a library, which is something the port should already support label Apr 24, 2020
@Neumann-A Neumann-A mentioned this issue Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[libarchive] expose zstd as a build feature Neumann-A/vcpkg
2 participants
@Neumann-A @JackBoosY