Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg-tool] vcpkg fetch should use correct version for folder names #43368

Open
Neumann-A opened this issue Jan 21, 2025 · 1 comment · May be fixed by microsoft/vcpkg-tool#1583
Open

[vcpkg-tool] vcpkg fetch should use correct version for folder names #43368

Neumann-A opened this issue Jan 21, 2025 · 1 comment · May be fixed by microsoft/vcpkg-tool#1583
Assignees
@MonicaLiu0311
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)

Comments

@Neumann-A
Copy link
Contributor

Example:

(vcpkg) PS D:\vcpkg_folders\no_msvc_project> .\vcpkg\vcpkg.exe fetch git
E:\vcpkg_cache\downloads\tools\git-2.7.4-windows\mingw64\bin\git.exe

in reality vcpkg currently downloads 2.43.0 so the version in the folder is misleading.
@MonicaLiu0311 MonicaLiu0311 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jan 21, 2025
@jimwang118 jimwang118 added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly and removed category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) labels Jan 22, 2025
@jimwang118 jimwang118 mentioned this issue Jan 22, 2025
Closed
7 tasks
@jimwang118 jimwang118 added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) and removed category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Jan 22, 2025
@BillyONeal
Copy link
Member

At the moment the folder name uses the minimum acceptable version rather than the downloaded version; the way we currently store that makes it ambiguous whether 'version' refers to what we need vs. what we know how to get.

@jimwang118 jimwang118 linked a pull request Jan 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Milestone
No milestone
4 participants
@BillyONeal @Neumann-A @MonicaLiu0311 @jimwang118