Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explore compiler defaulting host parameters from literals to strings with the literal value as a default #3821

Closed
3 tasks done
iscai-msft opened this issue Jul 11, 2024 · 4 comments
Assignees
Labels
needs-area needs-info Mark an issue that needs reply from the author or it will be closed automatically

Comments

@iscai-msft
Copy link
Member

Clear and concise description of the problem

There's continued discussion over whether host parameters should be generated as literal values, when guidelines say that host is something that can always be overridden. We don't want to make users explicitly define host as a value with a default every time, but emitters would like the . TCGC is going to special-case host params to be strings with default values (issue here), this issue is to eventually explore having the compiler do this instead of tcgc, which would be preferable if this is something that we want to provide to all emitters and emitter authors.

Checklist

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@timotheeguerin
Copy link
Member

Needs more info on what do you actually expect. And in scenarios like that what would you even want
Playground

  • When a server already parameterized
  • When multiple server
  • When multiple server including one parameterized and some not
  • When multiple server all parameterized differently

@timotheeguerin timotheeguerin added the needs-info Mark an issue that needs reply from the author or it will be closed automatically label Jul 11, 2024
@weidongxu-microsoft
Copy link
Contributor

weidongxu-microsoft commented Jul 12, 2024

I assume the "guidelines" here is Azure guideline, i.e. flavor=azure.

Would TCGC behave differently, if e.g flavor=generic ?

@timotheeguerin
Copy link
Member

I think if anything people 3rd party are way more likely to want to always have the baseUrl overridable.

Copy link
Contributor

Hi @iscai-msft. Since there hasn't been recent engagement, we're going to close this out. Please feel free to reopen if you have any further questions or concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area needs-info Mark an issue that needs reply from the author or it will be closed automatically
Projects
None yet
Development

No branches or pull requests

3 participants