Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving eliding of properties of type never lower #1128

Open
nguerrera opened this issue Oct 5, 2022 · 7 comments
Open

Consider moving eliding of properties of type never lower #1128

nguerrera opened this issue Oct 5, 2022 · 7 comments
Labels
design:needed A design request has been raised that needs a proposal
Milestone

Comments

@nguerrera
Copy link
Contributor

nguerrera commented Oct 5, 2022

  1. Should we move the skipping of properties of type never into MetadataInfo.isPayloadProperty?
    2. [Yes] Should we also elide metadata properties (header, query, etc.) of type never?

https://github.com/microsoft/cadl/pull/1127/files#r988024779

EDIT: Or should we go even farther and move this into the core, for example by having the checker drop the properties altogether?

@nguerrera
Copy link
Contributor Author

I think yes to both.

@daviwil
Copy link
Contributor

daviwil commented Oct 5, 2022

Beat me to it :) I think the answer to both is "yes" and "yes", though we can definitely discuss it in a design meeting.

@nguerrera nguerrera added the design:needed A design request has been raised that needs a proposal label Oct 5, 2022
@nguerrera
Copy link
Contributor Author

OK, I agree. This is ready to discuss and hopefully just a quick approval. :)

@ghost ghost added the Needs Triage label Oct 5, 2022
@bterlson
Copy link
Member

bterlson commented Oct 5, 2022

#TeamYesYes

@nguerrera
Copy link
Contributor Author

Leaving this as design we should also consider if it makes sense to go even lower into the core.

@nguerrera nguerrera changed the title [Metadata] Consider moving eliding of never eliding into metadata handling Consider moving eliding of properties of type never lower Oct 6, 2022
@markcowl markcowl added this to the [2022] November milestone Oct 10, 2022
@markcowl
Copy link
Contributor

@markcowl
Copy link
Contributor

Moving forward, need a proposal on whether to provide this functionality in helpers, or in the compiler

@markcowl markcowl modified the milestones: [2023] January, [2023] March Jan 4, 2023
@markcowl markcowl modified the milestones: [2023] March, Backlog Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design:needed A design request has been raised that needs a proposal
Projects
None yet
Development

No branches or pull requests

4 participants