Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

Improve notNeededPackages.json testing #515

Closed
ghost opened this issue Nov 14, 2018 · 1 comment
Closed

Improve notNeededPackages.json testing #515

ghost opened this issue Nov 14, 2018 · 1 comment
Assignees

Comments

@ghost
Copy link

ghost commented Nov 14, 2018

Currently we don't do any testing when notNeededPackages.json is changed. When a package is added to it we should ensure:

  • The directory it was in no longer exists.
  • Nothing depends on it.
  • The asOfVersion is higher than the last published version.
@sandersn
Copy link
Member

sandersn commented Mar 6, 2019

Also check that

  1. libraryName matches a real npm name.
  2. asOfVersion matches, for major.minor, a real version of the npm package.

When (1) is false, types-publisher crashes currently.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant