The 'import-name' rule threw an error. Cannot read property 'importClause' of undefined #667

joseSantacruz · 2018-12-04T21:30:51Z

Bug Report

tslint-microsoft-contrib version: 6.0.0
TSLint version:5.11.0
TypeScript version:3.1.6
Running TSLint via: CLI

TypeScript code being linted

// code snippet

with tslint.json configuration:

{
  "extends": ["tslint-microsoft-contrib"]
}

Actual behavior

The 'import-name' rule threw an error in '/Users/zerocooljs/Kushki/repo/kushki-usrv-snr/src/handler/SejiValidationHandler.ts':
TypeError: Cannot read property 'importClause' of undefined
    at ImportNameRuleWalker.visitImportDeclaration (/Users/zerocooljs/Kushki/repo/kushki-usrv-snr/node_modules/tslint-microsoft-contrib/importNameRule.js:138:54)
    at ImportNameRuleWalker.SyntaxWalker.visitNode (/Users/zerocooljs/Kushki/repo/kushki-usrv-snr/node_modules/tslint/lib/language/walker/syntaxWalker.js:392:22)
    at /Users/zerocooljs/Kushki/repo/kushki-usrv-snr/node_modules/tslint/lib/language/walker/syntaxWalker.js:535:63
    at visitNodes (/Users/zerocooljs/Kushki/repo/kushki-usrv-snr/node_modules/typescript/lib/typescript.js:15788:30)
    at Object.forEachChild (/Users/zerocooljs/Kushki/repo/kushki-usrv-snr/node_modules/typescript/lib/typescript.js:16016:24)
    at ImportNameRuleWalker.SyntaxWalker.walkChildren (/Users/zerocooljs/Kushki/repo/kushki-usrv-snr/node_modules/tslint/lib/language/walker/syntaxWalker.js:535:12)
    at ImportNameRuleWalker.SyntaxWalker.visitSourceFile (/Users/zerocooljs/Kushki/repo/kushki-usrv-snr/node_modules/tslint/lib/language/walker/syntaxWalker.js:228:14)
    at ImportNameRuleWalker.SyntaxWalker.visitNode (/Users/zerocooljs/Kushki/repo/kushki-usrv-snr/node_modules/tslint/lib/language/walker/syntaxWalker.js:482:22)
    at ImportNameRuleWalker.SyntaxWalker.walk (/Users/zerocooljs/Kushki/repo/kushki-usrv-snr/node_modules/tslint/lib/language/walker/syntaxWalker.js:24:14)
    at Rule.AbstractRule.applyWithWalker (/Users/zerocooljs/Kushki/repo/kushki-usrv-snr/node_modules/tslint/lib/language/rule/abstractRule.js:31:16)

Expected behavior

Rule should not crash and no linting issue should be found.

The text was updated successfully, but these errors were encountered:

IllusionMH · 2018-12-04T22:29:11Z

Hi @joseSantacruz , could you please provide provide reduced test case from SejiValidationHandler.ts that throws this error? Do you have dynamic imports in file?

I've tried to reproduce it, but got another exception:

import 'some-module';

leads to

The 'import-name' rule threw an error in 'C:/web/projects/tslint-microsoft-contrib/tests/import-name/test.ts':
TypeError: Cannot read property 'name' of undefined
    at ImportNameRuleWalker.visitImportDeclaration (C:\web\projects\tslint-microsoft-contrib\dist\src\importNameRule.js:127:31)
    at ImportNameRuleWalker.SyntaxWalker.visitNode (C:\web\projects\tslint-microsoft-contrib\node_modules\tslint\lib\language\walker\syntaxWalker.js:392:22)
    at C:\web\projects\tslint-microsoft-contrib\node_modules\tslint\lib\language\walker\syntaxWalker.js:535:63
    at visitNodes (C:\web\projects\tslint-microsoft-contrib\node_modules\typescript\lib\typescript.js:15788:30)
    at Object.forEachChild (C:\web\projects\tslint-microsoft-contrib\node_modules\typescript\lib\typescript.js:16016:24)
    at ImportNameRuleWalker.SyntaxWalker.walkChildren (C:\web\projects\tslint-microsoft-contrib\node_modules\tslint\lib\language\walker\syntaxWalker.js:535:12)
    at ImportNameRuleWalker.SyntaxWalker.visitSourceFile (C:\web\projects\tslint-microsoft-contrib\node_modules\tslint\lib\language\walker\syntaxWalker.js:228:14)
    at ImportNameRuleWalker.SyntaxWalker.visitNode (C:\web\projects\tslint-microsoft-contrib\node_modules\tslint\lib\language\walker\syntaxWalker.js:482:22)
    at ImportNameRuleWalker.SyntaxWalker.walk (C:\web\projects\tslint-microsoft-contrib\node_modules\tslint\lib\language\walker\syntaxWalker.js:24:14)
    at Rule.AbstractRule.applyWithWalker (C:\web\projects\tslint-microsoft-contrib\node_modules\tslint\lib\language\rule\abstractRule.js:31:16)

jvanoostveen · 2018-12-05T10:29:27Z

I'm seeing the Cannot read property 'name' of undefined as well.
When I check the files, I have some imports like:

import './polyfills';

and

import * as dependencies from '../page-dependencies';

IllusionMH · 2018-12-05T10:47:38Z

@jvanoostveen first one causes your exceptions, because there are no importClause in ImportStatement element.
Second should be processed just fine. Do you have problems with linter if you comment import './polyfills'; and similar lines?

jvanoostveen · 2018-12-05T11:16:37Z

For this import, we disable the linting rule: 'no-import-side-effect'. No other issues with crashing rules. But not all Microsoft contrib rules are enabled, so not all are tested.

IllusionMH · 2018-12-05T12:29:16Z

I'm waiting for some code that triggers initial exception and then will work on fix.

joseSantacruz · 2018-12-05T20:01:25Z

Hi @IllusionMH ,

this is the code of the SejiValidationHandler.ts

/**
 * Seji Validation Handler
 */
import {
  BUILDER_API_GATEWAY_MIDDLEWARE,
  ContentTypeEnum,
  ERROR_API_MIDDLEWARE,
  IDENTIFIERS as ID,
  IHandler,
  INPUT_OUTPUT_LOGS,
  IRollbar,
  SETUP_MIDDLEWARE,
  SSM_MIDDLEWARE,
  StatusCodeEnum,
  VALIDATION_MIDDLEWARE,
} from "@kushki/core";
import { IDENTIFIERS } from "constant/Identifiers";
import { CONTAINER } from "infrastructure/Container";
import * as middy from "middy";
import "reflect-metadata";
import { ISejiService } from "repository/ISejiService";
import * as Rollbar from "rollbar";
import "source-map-support/register";

const CORE: IHandler = CONTAINER.get<IHandler>(ID.IHandler);
const ROLLBAR: Rollbar = CONTAINER.get<IRollbar>(ID.IRollbar).init();
const HANDLER: middy.IMiddy = middy(
  ROLLBAR.lambdaHandler(
    CORE.run<
      ISejiService, // Service Definition
      object
    >( // Service observable resolve type
      IDENTIFIERS.SejiService, // Service instance
      "validate", // Service Method,
      CONTAINER,
      ROLLBAR
    )
  )
)
  .use(SETUP_MIDDLEWARE(ROLLBAR))
  .use(INPUT_OUTPUT_LOGS(ROLLBAR))
  .use(ERROR_API_MIDDLEWARE(ROLLBAR))
  .use(SSM_MIDDLEWARE(ROLLBAR))
  .use(
    BUILDER_API_GATEWAY_MIDDLEWARE(
      ROLLBAR,
      ContentTypeEnum.JSON,
      StatusCodeEnum.OK,
      ContentTypeEnum.JSON,
      true
    )
  )
  .use(
    VALIDATION_MIDDLEWARE(ROLLBAR, {
      path: "seji_validate_pathparameters",
    })
  );

export { HANDLER };

And in case is usefull this is my current tsconfig

{
  "compilerOptions": {
    "module": "commonjs",
    "moduleResolution": "node",
    "noImplicitAny": false,
    "target": "es2016",
    "lib": ["es2017", "dom"],
    "sourceMap": true,
    "alwaysStrict": true,
    "baseUrl": ".",
    "types": ["mocha", "node", "reflect-metadata"],
    "experimentalDecorators": true,
    "allowSyntheticDefaultImports": true,
    "emitDecoratorMetadata": true,
    "noStrictGenericChecks": true,
    "paths": {
      "handler/*": ["src/handler/*"],
      "constant/*": ["src/constant/*"],
      "gateway/*": ["src/gateway/*"],
      "infrastructure/*": ["src/infrastructure/*"],
      "model/*": ["src/model/*"],
      "repository/*": ["src/repository/*"],
      "service/*": ["src/service/*"],
      "typings": ["typings.d.ts"],
      "utils/*": ["src/utils/*"],
      "error/*": ["src/error/*"],
      "types/*": ["types/*"]
    }
  },
  "exclude": ["node_modules"]
}

IllusionMH · 2018-12-05T20:25:55Z

@joseSantacruz thanks for your code.
Strange but I receive different exception: TypeError: Cannot read property 'name' of undefined (which I've mentioned earlier).

Could you please comment lines

import "reflect-metadata";

and

import "source-map-support/register";

and try lint again.

And what node.js version do you use? Maybe something changed in exceptions reports.

joseSantacruz · 2018-12-05T20:56:07Z

@IllusionMH after removing the imports the error disappears, my node version is 8.10.0. So I think the error should be the same

IllusionMH · 2018-12-05T22:10:25Z

Really strange.

$ node -v
v8.10.0

$ ./node_modules/.bin/tslint -v
5.11.0

$ ./node_modules/.bin/tsc -v
Version 3.1.6

$ cat ./node_modules/tslint-microsoft-contrib/package.json | grep version
    "type": "version",
  "version": "6.0.0"

But still I can't get TypeError: Cannot read property 'importClause' of undefined. Will try to run in Linux container later.

The other strange thing is stack trace. Where traces are identical except only line numbers of last string:

    at ImportNameRuleWalker.visitImportDeclaration (/Users/zerocooljs/Kushki/repo/kushki-usrv-snr/node_modules/tslint-microsoft-contrib/importNameRule.js:138:54)

And in my case (for 6.0.0) I have

    at ImportNameRuleWalker.visitImportDeclaration (C:\web\test\import-repro\node_modules\tslint-microsoft-contrib\importNameRule.js:127:31)

and visitImportDeclaration ends on 135 line, so exception cannot be on line 138 (can be only if there are some padding at the top of the module).

I'm out of ideas at this moment.

@joseSantacruz could you please show what params do you pass in tslint when run it from CLI? Is there a chance that there is \r line ending instead of \n ?
Added. And may be content of your node_modules/tslint-microsoft-contrib/importNameRule.js if it is 6.0.0 version in node_modules/tslint-microsoft-contrib/package.json (I'm understand that list of requests is long and annoying, but I'm ran out of ideas how to reproduce your case 😞 )

UPD. No luck with Linux. Tried it Docker container - still same error as on Windows.
So may be there is some version mismatch or node_modules/tslint-microsoft-contrib/importNameRule.js file somehow altered (is there any difference with fresh package install in separate folder?) or IDK

Will proceed with fix for TypeError: Cannot read property 'name' of undefined. Maybe it will help with original one, or someone will find a way to reproduce it.

joseSantacruz · 2018-12-10T15:05:09Z

Hi @IllusionMH

this is the command that I'm running npx tslint -t stylish --project tsconfig.json -c tslint.json 'src/**/*.ts'

dfee · 2019-01-03T22:03:11Z

I just came across this too. It was because my index.sass file is imported like this: import './index.sass'.

I guess I'll wait for this to be merged into the next release.

startswithaj · 2019-01-09T00:38:18Z

I'm also finding I have the same error since updating package.

The 'import-name' rule threw an error in '/Users/jake/dev/citrus/citrus-client/src/app/app.module.ts':
TypeError: Cannot read property 'name' of undefined

It's imports like these
import 'rxjs/add/operator/switchMap';

I've tried disabling the rule for that line, but it must try and parse it anyway.

Cayan · 2019-02-16T10:17:21Z

I receive this error when I try to import core-js

JoshuaKGoldberg · 2020-01-11T03:56:57Z

💀 It's time! 💀

TSLint is deprecated and no longer accepting pull requests other than security fixes. See #876. ☠️
We recommend you instead use typescript-eslint to lint your TypeScript code with ESLint. ✅

👋 It was a pleasure open sourcing with you!

IllusionMH mentioned this issue Dec 10, 2018

Enabled no-non-null-assertion internally #669

Merged

JoshuaKGoldberg added Type: Bug Status: Accepting PRs labels Dec 11, 2018

JoshuaKGoldberg mentioned this issue Dec 13, 2018

import-name rule is missing tests for import "some-name"; #671

Closed

christophka mentioned this issue Jan 8, 2019

Linting rule 'import-name' throws error environment-agency-austria/react-ocean-forms-bootstrap#36

Closed

JoshuaKGoldberg closed this as completed Jan 11, 2020

JoshuaKGoldberg added 💀 R.I.P. 💀 and removed Status: Accepting PRs labels Jan 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The 'import-name' rule threw an error. Cannot read property 'importClause' of undefined #667

The 'import-name' rule threw an error. Cannot read property 'importClause' of undefined #667

joseSantacruz commented Dec 4, 2018 •

edited

Loading

IllusionMH commented Dec 4, 2018 •

edited

Loading

jvanoostveen commented Dec 5, 2018

IllusionMH commented Dec 5, 2018

jvanoostveen commented Dec 5, 2018

IllusionMH commented Dec 5, 2018

joseSantacruz commented Dec 5, 2018

IllusionMH commented Dec 5, 2018

joseSantacruz commented Dec 5, 2018

IllusionMH commented Dec 5, 2018 •

edited

Loading

joseSantacruz commented Dec 10, 2018 •

edited

Loading

dfee commented Jan 3, 2019

startswithaj commented Jan 9, 2019

Cayan commented Feb 16, 2019

JoshuaKGoldberg commented Jan 11, 2020

The 'import-name' rule threw an error. Cannot read property 'importClause' of undefined #667

The 'import-name' rule threw an error. Cannot read property 'importClause' of undefined #667

Comments

joseSantacruz commented Dec 4, 2018 • edited Loading

Bug Report

TypeScript code being linted

Actual behavior

Expected behavior

IllusionMH commented Dec 4, 2018 • edited Loading

jvanoostveen commented Dec 5, 2018

IllusionMH commented Dec 5, 2018

jvanoostveen commented Dec 5, 2018

IllusionMH commented Dec 5, 2018

joseSantacruz commented Dec 5, 2018

IllusionMH commented Dec 5, 2018

joseSantacruz commented Dec 5, 2018

IllusionMH commented Dec 5, 2018 • edited Loading

joseSantacruz commented Dec 10, 2018 • edited Loading

dfee commented Jan 3, 2019

startswithaj commented Jan 9, 2019

Cayan commented Feb 16, 2019

JoshuaKGoldberg commented Jan 11, 2020

💀 It's time! 💀

joseSantacruz commented Dec 4, 2018 •

edited

Loading

IllusionMH commented Dec 4, 2018 •

edited

Loading

IllusionMH commented Dec 5, 2018 •

edited

Loading

joseSantacruz commented Dec 10, 2018 •

edited

Loading