Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Use a walk function instead of extending AbstractRule in our new-rule templates #586

Closed
JoshuaKGoldberg opened this issue Oct 25, 2018 · 0 comments · Fixed by #702
Closed

Use a walk function instead of extending AbstractRule in our new-rule templates #586

JoshuaKGoldberg opened this issue Oct 25, 2018 · 0 comments · Fixed by #702
Labels
Difficulty: Medium People with non-trivial experience in TSLint should be able to send a pull request for this issue. Domain: Tooling Repository tasks around improving source tooling. Status: Accepting PRs
Milestone
6.1.0-beta

Comments

@JoshuaKGoldberg
Copy link

See palantir/tslint#2522. We should be recommending a ts.forEachChild strategy in what's now rule.snippet and will become rule-snippet.js after #584.
@JoshuaKGoldberg JoshuaKGoldberg added Status: Accepting PRs Difficulty: Medium People with non-trivial experience in TSLint should be able to send a pull request for this issue. Domain: Tooling Repository tasks around improving source tooling. Hacktoberfest and removed Hacktoberfest labels Oct 25, 2018
@reduckted reduckted mentioned this issue Oct 29, 2018
Closed
@reduckted reduckted mentioned this issue Dec 15, 2018
Closed
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 15, 2018
Closed
@reduckted reduckted mentioned this issue Dec 28, 2018
Merged
2 tasks
@IllusionMH IllusionMH added this to the 6.1.0-beta milestone Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Difficulty: Medium People with non-trivial experience in TSLint should be able to send a pull request for this issue. Domain: Tooling Repository tasks around improving source tooling. Status: Accepting PRs
Projects
None yet
Milestone
6.1.0-beta
Development

Successfully merging a pull request may close this issue.

586 walk in new rule template
2 participants
@IllusionMH @JoshuaKGoldberg