Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Update react-a11y-img-has-alt - area elements of image maps have alternate text #223

Closed
HamletDRC opened this issue Sep 2, 2016 · 6 comments
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Domain: Accessibility Rules around accessibility verification, commonly react-a11y-*. Status: Accepting PRs Type: Rule Feature Adding a feature to an existing rule.

Comments

@HamletDRC
Copy link
Member

area elements of image maps have alternate text - wcag2a, wcag111, section508, section508.22.a - From area-alt

@JoshuaKGoldberg JoshuaKGoldberg added Status: Accepting PRs Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Type: Rule Feature Adding a feature to an existing rule. Domain: Accessibility Rules around accessibility verification, commonly react-a11y-*. labels Jul 4, 2018
@cthulhu-uu
Copy link

This is my first time in this repo and I'd like to contribute for Hacktoberfest. Can you please clarify what change is being requested? Thanks!

@JoshuaKGoldberg
Copy link

Awesome, welcome to the repo @cthulhu-uu! The more PRs the merrier.

I believe the issue is asking that the <area> element declared in <map> elements should be validated similar to regular <img> tags, in that they must have an alt attribute.

This should cause a react-a11y-image-has-alt complaint:

<map name="infographic">
    <area shape="poly" coords="7,35,49" href="/HTML" target="_blank" />
</map>

...but this should not (because of the alt):

<map name="infographic">
    <area shape="poly" coords="7,35,49" href="/HTML" target="_blank" alt="Happy face" />
</map>

/cc @HamletDRC in case I'm horribly wrong.

Is that the clarification you were looking for?

@cthulhu-uu
Copy link

@Chovin something you want to look at? 👀

@Chovin
Copy link

Chovin commented Oct 8, 2018

I'd love to take this on if that's alright. Thanks @cthulhu-uu! ❤️

@Chovin
Copy link

Chovin commented Oct 14, 2018

does the presentation role thing apply to these guys as well? where a null alt attribute is allowed if there is a role="presentation"?

@JoshuaKGoldberg
Copy link

☠️ It's time! ☠️

Per #876, this repository is no longer accepting feature pull requests. TSLint is being deprecated and we recommend you switch to https://typescript-eslint.io.

Thanks for open sourcing with us, everyone!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Domain: Accessibility Rules around accessibility verification, commonly react-a11y-*. Status: Accepting PRs Type: Rule Feature Adding a feature to an existing rule.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants