Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove @override #322

Closed
Gerrit0 opened this issue Apr 24, 2022 · 2 comments · Fixed by microsoft/rushstack-websites#258
Closed

Deprecate and remove @override #322

Gerrit0 opened this issue Apr 24, 2022 · 2 comments · Fixed by microsoft/rushstack-websites#258

Comments

@Gerrit0
Copy link
Contributor

Gerrit0 commented Apr 24, 2022

TypeScript 4.3 introduced the override keyword, which appears to have the same semantics as this tag, with the benefit of being directly recognized by the language. As such, for recent TS versions this tag is potential for confusion. It should either be deprecated / removed, or it's documentation updated to clarify why it exists alongside the keyword and when it should be used instead/in addition to the keyword.

@zelliott
Copy link

zelliott commented May 6, 2022

The override keyword isn't present in the .d.ts (microsoft/TypeScript#2000 (comment)) and API Extractor runs on .d.ts. Playground. This should be mentioned in the documentation at https://tsdoc.org/pages/tags/override/. Thoughts @octogonz?

@SmashingQuasar
Copy link

I second @Gerrit0's issue regarding this tag. It should be deprecated.
However, is TSDoc handling the native override keyword?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants