Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeclarationReference: Parser allows unquoted spaces #179

Open
octogonz opened this issue Aug 7, 2019 · 1 comment
Open

DeclarationReference: Parser allows unquoted spaces #179

octogonz opened this issue Aug 7, 2019 · 1 comment

Comments

@octogonz
Copy link
Collaborator

octogonz commented Aug 7, 2019

(Issue #174 was mostly solved by PR #177, so I'm creating a new issue to track this issue with spaces.)

Repro:

// (Actual) a.b c.d
// (Expected) SyntaxError
console.log(DeclarationReference.parse('a.b c.d').toString());

Since the DeclarationReference.parse() accepts escaped input, the parser should require the input to be quoted as a."b c".d. @rbuckton does that sound right?

@octogonz
Copy link
Collaborator Author

octogonz commented Dec 9, 2019

Hmm... In the current implementation, DeclarationReference.parse('a.b c.d').toString() outputs "a.b c.d".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant