Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging messages to be localized #4133

Open
Youssef1313 opened this issue Nov 23, 2024 · 1 comment
Open

Logging messages to be localized #4133

Youssef1313 opened this issue Nov 23, 2024 · 1 comment
Assignees

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Nov 23, 2024

Hang dump (#4145)

await _logger.LogInformationAsync($"Hang dump timeout setup {_activityTimerValue}.");

await _logger.LogInformationAsync($"Hang dump timeout({_activityTimerValue}) expired.");

await _logger.LogInformationAsync($"Creating dump filename {finalDumpFileName}");

MTP configurations

await LogInformationAsync($"Config file '{configFileName}' not found.");

await LogInformationAsync($"Config file '{configFileName}' loaded.");

MTP hosts

await _logger.LogInformationAsync($"Starting test session '{ServiceProvider.GetTestSessionContext().SessionId}'");

await _logger.LogInformationAsync($"Test session '{ServiceProvider.GetTestSessionContext().SessionId}' ended with exit code '{exitCode}' in {consoleRunStarted.Elapsed}");

await _logger.LogInformationAsync("Test session canceled.");

await _logger.LogInformationAsync($"TestHostControllersTestHost ended with exit code '{exitCode}' (real test host exit code '{testHostProcess.ExitCode}')' in '{consoleRunStarted.Elapsed}'");

MTP requests

await logger.LogInformationAsync($"Test framework UID: '{testFramework.Uid}' Version: '{testFramework.Version}' DisplayName: '{testFramework.DisplayName}' Description: '{testFramework.Description}'");
(Related to AB#2275339)

@Evangelink
Copy link
Member

Evangelink commented Nov 25, 2024

@Youssef1313 The logs should remain unlocalized as they are technical diagnostic info. If we start to localize them, we will have hard time diagnostising user issues.

For the issue with Test Explorer, I think we instead need to review the current logic as we probably don't want the logs to be brought up to TE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants