Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8167: Fix TabTests - use tab 0 rather than value 0 #8168

Merged
1 commit merged into from
Nov 5, 2020
Merged

8167: Fix TabTests - use tab 0 rather than value 0 #8168

1 commit merged into from
Nov 5, 2020

Conversation

Don-Vito
Copy link
Contributor

@Don-Vito Don-Vito commented Nov 5, 2020 •
edited by DHowett
Loading

A fix for UTs crashing due to bad memory access (accessing page 0).
Regression from #8153
Closes #8167

@Don-Vito Don-Vito mentioned this pull request Nov 5, 2020
Merged
6 tasks
@Don-Vito
Copy link
Contributor Author

Don-Vito commented Nov 5, 2020

@DHowett - we really need to make those tests run in CI

zadjii-msft
zadjii-msft approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I hate that the compiler didn't even catch this one 😑

@zadjii-msft zadjii-msft added AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off labels Nov 5, 2020
@ghost
Copy link

ghost commented Nov 5, 2020

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 5 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

DHowett
DHowett approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof.

@DHowett
Copy link
Member

DHowett commented Nov 5, 2020

@msftbot merge this in 4 minutes

@ghost
Copy link

ghost commented Nov 5, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 05 Nov 2020 17:17:33 GMT, which is in 4 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@Don-Vito
Copy link
Contributor Author

Don-Vito commented Nov 5, 2020

I guess we need to rerun CI.. again..
Can we disable the UTs that continue to randomly fail, until we fix them?

@DHowett
Copy link
Member

DHowett commented Nov 5, 2020

The weird thing is that it's a different set each time. I'm not certain I want to disable that many tests for this weird infrastructure issue.

Curious about what's happening though...
I wonder if TE can take a process dump at the time of failure.

@Don-Vito
Copy link
Contributor Author

Don-Vito commented Nov 5, 2020

The weird thing is that it's a different set each time. I'm not certain I want to disable that many tests for this weird infrastructure issue.

Curious about what's happening though...
I wonder if TE can take a process dump at the time of failure.

Locally I am running with /breakOnError which invokes Windbg. Probably we can do something similar.

@ghost ghost merged commit 5de4f98 into microsoft:main Nov 5, 2020
@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal Preview v1.5.3142.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 11, 2020
Closed
@Don-Vito Don-Vito deleted the 8167-fix-ut branch December 3, 2020 17:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett DHowett DHowett approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TabTests fail with AccessViolation as 0 is passed to _GetTerminalTabImpl
4 participants
@Don-Vito @DHowett @carlos-zamora @zadjii-msft