Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immediately show the cursor on terminal focus #4032

Merged
1 commit merged into from
Dec 30, 2019
Merged

Conversation

dkter
Copy link
Contributor

@dkter dkter commented Dec 21, 2019

Summary of the Pull Request

Before, when a terminal window was focused, the blinking cursor would initially be hidden. This PR will immediately show the cursor when the window is focused, making it easier to keep track of the cursor.

References

#3761

PR Checklist

Detailed Description of the Pull Request / Additional comments

I guess I'm the cursor guy now

Validation Steps Performed

  • Switched rapidly between different panes, different tabs and focused and unfocused the main window repeatedly.

Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm the cursor guy now

If you’re alright with that title, I’m very happy to have a cursor guy in our community. Happy holidays; I can’t promise a second review on account of all our overlapping vacations, of course. :)

@DHowett-MSFT DHowett-MSFT added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 24, 2019
@ghost
Copy link

ghost commented Dec 24, 2019

Hello @DHowett-MSFT!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow yea that's easy

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhg I meant approve

@ghost ghost merged commit e2a66c4 into microsoft:master Dec 30, 2019
@ghost
Copy link

ghost commented Jan 14, 2020

🎉Windows Terminal Preview v0.8.10091.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When changing focus the cursor has significant delay before appearing.
3 participants