-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FHL] Make VTApiRoutines, which does VT translation for output #11264
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
eebed6a
Make a VTApiRoutines servicer that does minimal translations instead …
miniksa 759a919
the rest of the stuff I did on Tuesday.
miniksa 9325839
cooked read in cmd works omg.
miniksa 3314e4a
remove one bit of badness
miniksa 3372462
fix a thing where we would see the cursor on offs because it did not …
miniksa 9277ff3
Define feature for this. Start piping through setting.
miniksa 7549a04
change activation mechanism for passthrough
miniksa 9bc88d3
argument/option for passthrough mode
miniksa f048c7d
some pre-review cleanup
miniksa 8981585
have a few commas
miniksa 338e62c
code format!
miniksa d23b9b0
fix some build errors
miniksa 4749b68
more build fixes
miniksa 1151239
code format
miniksa b43fa07
fix these tests by allocating the api handler.
miniksa 08415e7
revert write change as it causes infinite loops with emoji
miniksa ea2a551
WELL THAT WAS EASY (to add the Settings UI toggle.)
miniksa dd83607
code format
miniksa 5e740c8
take a different strategy for the default api routines since so many …
miniksa c85b2c9
unify includes beteween host and test project to the common one.
miniksa 3383816
some PR comment odds and ends
miniksa 7cb22a1
more PR feedback shuffling.
miniksa cd58080
code format!
miniksa 379224a
rearrange public/private
miniksa 85ae5bf
Messed up merge + a nit
miniksa daa154c
more bad merge
miniksa 063ad97
ok pull this in
miniksa 7b2e216
code format!
miniksa f070e89
actually check the setting before passing the flag down
miniksa 72e8ecc
Apply correct style to toggleswitch
miniksa df4614e
address feedback
miniksa d6d8521
Merge remote-tracking branch 'origin/main' into dev/miniksa/vtapi
DHowett b348b29
Merge remote-tracking branch 'origin/main' into dev/miniksa/vtapi
DHowett 61e8822
Only instantiate VtApiEtc if the feature is on
DHowett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not compile in Release. You are using a preprocessor define to control whether the constant is visible, but a
constexpr if
(which must compile successfully) wherein you are using the constant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, you're gating the presence of the member using the preprocessor as well.
Try a build from the commandline with
/p:WindowsTerminalBranding=Release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say, keep the member and the constant defined and only gate whether the code actually touches them based on
if constexpr