Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When saving new settings should check for missing font and alert. #8180

Closed
bwilsonms opened this issue Nov 6, 2020 · 2 comments
Closed

When saving new settings should check for missing font and alert. #8180

bwilsonms opened this issue Nov 6, 2020 · 2 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@bwilsonms
Copy link

Environment

Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.19042.0 Microsoft Windows NT 10.0.19042.0
Windows Terminal Preview
Version: 1.4.2652.0

Any other software?

Steps to reproduce

  1. Download LiterationMono NF font from nerdfonts.com
  2. Edit settings for pwsh 7+ with the following lines:
    "hidden": false,
    "name": "PowerShell",
    "source": "Windows.Terminal.PowershellCore",
    "useAcrylic": true,
    "acrylicOpacity": 0.7,
    "fontFace": "LiterationMono NF ", <<<<<< Notice trailing space
    "colorScheme": "Frost",
    "cursorColor" : "#000000",

Expected behavior

An alert that font is not found

Actual behavior

Setting file saves without warning but font is not found and icon packs are not in use.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 6, 2020
@miniksa
Copy link
Member

miniksa commented Nov 6, 2020

Thanks for the report!

This happens to be a duplicate issue, but I'll go try to make sure the linked issue is ranked for Terminal 2.0.

/dup #1017

@ghost
Copy link

ghost commented Nov 6, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 6, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 6, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants