Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for null Profile.StartingDirectory #7423

Open
carlos-zamora opened this issue Aug 26, 2020 · 0 comments
Open

Add test for null Profile.StartingDirectory #7423

carlos-zamora opened this issue Aug 26, 2020 · 0 comments
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Engineering Impro...

Comments

@carlos-zamora
Copy link
Member

Description of the new feature/enhancement

"startingDirectory": null has significant value. It inherits the starting directory of its parent process.

There is no testing today that covers this case.
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels Aug 26, 2020
@carlos-zamora carlos-zamora added this to the Terminal v2.0 milestone Aug 26, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 26, 2020
@carlos-zamora carlos-zamora mentioned this issue Aug 26, 2020
Merged
2 tasks
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 27, 2020
@carlos-zamora carlos-zamora mentioned this issue Aug 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Engineering Improvements
Development

No branches or pull requests
3 participants
@DHowett @carlos-zamora @zadjii-msft