Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpf: TerminalContainer consumes WM_MOUSEWHEEL and doesn't let the native HWND have it #6996

Open
Tracked by #6999
DHowett opened this issue Jul 22, 2020 · 4 comments
Open
Tracked by #6999

wpf: TerminalContainer consumes WM_MOUSEWHEEL and doesn't let the native HWND have it #6996

DHowett opened this issue Jul 22, 2020 · 4 comments
Assignees
@DHowett
Labels
Area-WPFControl Things related to the WPF version of the TermControl Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@DHowett
Copy link
Member

DHowett commented Jul 22, 2020

This makes VT mouse scrolling events not work.
@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Priority-2 A description (P2) Area-WPFControl Things related to the WPF version of the TermControl labels Jul 22, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 22, 2020
@DHowett
Copy link
Member Author

DHowett commented Jul 2, 2021

@javierdlg Curious if this was an intentional design or not -- giving WM_MOUSEWHEEL support to the HWND instead of the Container will let us send "wheel events" to the connected console application 😄

@DHowett DHowett added this to the Terminal v2.0 milestone Jul 2, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 2, 2021
@DHowett DHowett self-assigned this Jul 2, 2021
@javierdlg
Copy link
Member

@DHowett hard to say if this was intentional, that section was implemented by Zoey who sadly already left MS. If we're able to forward these to the HWND without breaking the WPF I'm okay with the change.

@javierdlg
Copy link
Member

On another note, are there more people using the WPF container for the terminal?

@DHowett
Copy link
Member Author

DHowett commented Jul 3, 2021

I'm not certain- if they are, they haven't told me 😄

@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft mentioned this issue Jul 5, 2023
Open
3 tasks
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

Labels
Area-WPFControl Things related to the WPF version of the TermControl Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@DHowett @javierdlg @zadjii-msft