Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround "When we add a new tab in compact mode, re-enforce Compact mode" #6681

Closed
zadjii-msft opened this issue Jun 25, 2020 · 8 comments · Fixed by #7447
Closed

Remove workaround "When we add a new tab in compact mode, re-enforce Compact mode" #6681

zadjii-msft opened this issue Jun 25, 2020 · 8 comments · Fixed by #7447
Assignees
@marcelwgn
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@zadjii-msft
Copy link
Member

When we get a version of WinUI with a fix for microsoft/microsoft-ui-xaml#2711, we can go ahead and revert #6670. This task is tracking that future work.
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels Jun 25, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Jun 25, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 25, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 25, 2020
@DHowett
Copy link
Member

DHowett commented Jun 25, 2020

Triaged

@marcelwgn
Copy link
Contributor

The new prerelease of WinUI (2.5.0.prerelease.200708003) contains the fix for TabView, so with that prerelease, the workaround can be removed.

@marcelwgn
Copy link
Contributor

I would like to work on this issue.

@zadjii-msft
Copy link
Member Author

Go right ahead! You'll probably need to bump our MUX version up across the entire solution. I'd take a look at https://github.com/microsoft/terminal/blob/master/doc/building.md#updating-nuget-package-references for a quick and dirty script for doing that part ☺️

@marcelwgn
Copy link
Contributor

marcelwgn commented Aug 28, 2020 •
edited
Loading

Thanks for the link, I just noticed that for some reason, in the documentation, I chose to make the Oldversion higher then the Newversion. Mind if I create a separate PR to fix this? The current way it is presented might be a bit confusing for other folks reading that part.

@zadjii-msft
Copy link
Member Author

Oh yea totally - that's probably my bad from the last time I used this script. It probably also bumped the version number within the script itself 😃

@marcelwgn
Copy link
Contributor

Oh right haha, just noticed it doing this on my machine too! Maybe we should choose some nonexistent versions so this doesn't happen again 🤔?

@zadjii-msft
Copy link
Member Author

Yea probably haha

@marcelwgn marcelwgn mentioned this issue Aug 28, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 28, 2020
@marcelwgn marcelwgn mentioned this issue Aug 28, 2020
Merged
6 tasks
@ghost ghost closed this as completed in #7447 Sep 4, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Sep 4, 2020
ghost pushed a commit that referenced this issue Sep 4, 2020
@marcelwgn
Update to a newer MUX prerelease; remove workaround for compact sizing (
5330759 
#7447)

Update the WinUI version which allows us to remove the workaround.

Closes #6681
@Sidneys1 Sidneys1 mentioned this issue Sep 7, 2020
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcelwgn marcelwgn

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Update to a newer MUX prerelease; remove workaround for compact sizing
3 participants
@DHowett @marcelwgn @zadjii-msft