Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Terminal needs to support "cursorTextColor": null #6338

Open
zadjii-msft opened this issue Jun 3, 2020 · 2 comments
Open

The Terminal needs to support "cursorTextColor": null #6338

zadjii-msft opened this issue Jun 3, 2020 · 2 comments
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@zadjii-msft
Copy link
Member

Follow up from #6337

Spec'd in #6151

Currently, the terminal always draws the cursor on top of text. #6337 is going to change the Terminal to always draw the cursor underneath the text. Before we release a build with #6337 in it, we should add a setting to allow users to return to the current behavior.
@zadjii-msft zadjii-msft added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Severity-Blocking We won't ship a release like this! No-siree. labels Jun 3, 2020
@zadjii-msft zadjii-msft added this to the Terminal v1.1 milestone Jun 3, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 3, 2020
@zadjii-msft zadjii-msft mentioned this issue Jun 3, 2020
Merged
3 tasks
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 5, 2020
@DHowett
Copy link
Member

DHowett commented Jun 5, 2020

We have a workaround, so I'm going to yank Blocking.

@DHowett DHowett removed the Severity-Blocking We won't ship a release like this! No-siree. label Jun 5, 2020
@zadjii-msft
Copy link
Member Author

For the record, the workaround is use "cursorShape": "vintage", "cursorHeight": 100.

This is blocked on the spec being approved over in #6151, so I'm gonna move it to 2.0.

@zadjii-msft zadjii-msft mentioned this issue Dec 9, 2021
Open
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@DHowett @zadjii-msft