-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font rendering issues in Terminal #610
Comments
@miniksa is the guy who will know why this is happening. |
Is "SF" the San Francisco font from Apple that we're absolutely not authorized nor licensed to use outside of an Apple computer? If so, I can't investigate this and have to slam it closed. I can't debug/diagnose fonts I'm not licensed to use and I can't condone having other people break that license agreement. |
No, that is SF Mono. SF Console is a clone intended to look like it but not one I'm authorized to share; which is why I mention Roboto Slab, which is open source and publicly available. |
Where can I get it and confirm the licensing? |
It's made by Google, released under the Apache 2.0 license. GitHub repo: https://github.com/googlefonts/robotoslab You can download the prebuilt TrueType files here: https://github.com/google/fonts/tree/master/apache/robotoslab |
OK thanks. I'll take a look at it then when I get around to being able to work on rendering stuff instead of triaging GitHub issues and PRs all day. :P |
I'm having a similar issue, I can only seem to use the base regular font, any medium or other variation and the app won't start and changes to a very tiny clipped variation if already running similar to the 4th screenshot. Font is Fira Code. Fira Code Medium works fine everywhere else. |
If the new terminal is going to support Bold and Italic fonts, shouldn't the font picker be showing Font Families, rather than individual fonts? |
I mean, there isn’t a font picker right now, so it isn’t showing anything? |
True, but the fact the font picked is not of a regular weight, it could be part of the problem. But I assume the plan is to have a font picker in an app setting dialog of some kind :) |
I think a good question is whether individual fonts within a family are looked up by their common name or their postscript name. |
Also maybe related: #1163 |
This issue occurs with any font using the non-regular weight. For Example, IBM Plex Mono provides a ton of weights, none of them work in the terminal except regular specified with |
Same for Nerd Fonts. As long as regular is installed, regular will be used. If you uninstall everything but, say for example bold, bold is used instead. This should instead be configurable in the settings file, with another attribute (e.g. {
"acrylicOpacity" : 0.5,
"closeOnExit" : true,
"colorScheme" : "One Dark Pro",
"commandline" : "wsl.exe -d Debian",
...
"fontFace" : "Hack NF",
"fontSize" : 11,
"fontWeight": "bold",
...
"useAcrylic" : true
} |
Thanks for the datapoint. I don't think I tried non-"regular" font weights yet while originally writing the renderer. This is probably just something I overlooked and need to finish writing.
I agree, it should be configurable. I just haven't got around to it yet. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Not sure where to file this. Could be in Cascadia Code itself @cinnamon-msft or could be Terminal Version: 0.9.433.0. Repro is easy. "echo ⚡" with Cascadia Code PL vs using the patched DelugiaCode NF. Note it on the command line vs when used in a prompt. This is DelugiaCodeNF 1909.16 (just a patched Cascadia). It's not in color on the prompt, then it's color in the prompt. But the size is right. And this is Cascadia Code PL 1911.21. It's color everywhere but tiny. |
@shanselman Is the color part a bug? It looks to me like a lightning bolt glyph was added into the patched font and that the unpatched font is falling back on the default Windows emoji glyph. |
@austinwagner The bug (behaviorally) is the small/wrong size. You're saying that Cascadia has a small glyph inside and that is wrong? |
@shanselman Apologies for being unclear. I was referring to the color difference only. The size is almost certainly wrong. |
This comment has been minimized.
This comment has been minimized.
Good, good, y'all can head over to #900 |
This is in fact a bug submitted by @shanselman himself so 🤷♂ |
I followed the instructions by @shanselman post https://www.hanselman.com/blog/HowToMakeAPrettyPromptInWindowsTerminalWithPowerlineNerdFontsCascadiaCodeWSLAndOhmyposh.aspx and I still see wonky icons. Windows Terminal version 0.9.433.0 |
@calloncampbell I'll help you via twitter, not in a GH issue |
OK my issue is not related. I had downloaded the wrong font. Thanks @shanselman for the help. |
This comment has been minimized.
This comment has been minimized.
@miniksa FYI the wonky icons comment was due to an uninstalled font |
With the completion of this checklist: #610 (comment), I am deeming this bug closed and resolved by other issues on the tracker. Thanks. Please file new issues against the latest version if there are still problems not addressed or covered by the open #900 or #455. |
@miniksa were you able to get around the fontWeight config var? |
I have Terminal up and running under 18362.0, but it seems to have problems with certain types of fonts.
Here it is working fine with the font set to "SF Console":
But it breaks when the font is changed to "SF Console Medium" (but not because the font isn't found or anything). The app doesn't crash but the text is rendered... let's just say extremely incorrectly:
If you focus extremely well and zoom in all the way, you can see that text is being rendered.. just very oddly so. Change the font back and it redraws correctly to what it used to contain.
Here's the same screenshot from conhost with the font set to "SF Console Medium" via the registry:
It's not just an issue with setting a variant of a font, or this particular font. Here's how the default (free) "Roboto Slab" is rendered, but I'm not sure if it's the same problem (it doesn't look like it):
The text was updated successfully, but these errors were encountered: