Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TerminalCore Selection Code to use til::point #5814

Closed
carlos-zamora opened this issue May 8, 2020 · 2 comments
Closed

Refactor TerminalCore Selection Code to use til::point #5814

carlos-zamora opened this issue May 8, 2020 · 2 comments
Assignees
@lhecker
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.15

Comments

@carlos-zamora
Copy link
Member

The selection code in TerminalCore can be rewritten to use til::point. We should do that.
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels May 8, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 8, 2020
@carlos-zamora carlos-zamora mentioned this issue May 8, 2020
Closed
5 tasks
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone May 11, 2020
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 12, 2020
@carlos-zamora
Copy link
Member Author

Moving to v2 milestone because I think I'll try to just focus on selection for like a month.

@carlos-zamora carlos-zamora self-assigned this May 12, 2020
@carlos-zamora carlos-zamora mentioned this issue May 21, 2020
Open
25 tasks
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label May 20, 2021
@carlos-zamora carlos-zamora removed the Help Wanted We encourage anyone to jump in on these. label Dec 9, 2021
@zadjii-msft
Copy link
Member

hey guys we did this in #13025 (et al)

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.15
Development

No branches or pull requests
3 participants
@lhecker @carlos-zamora @zadjii-msft