Move the solution to VS2019 and v142 toolset

[chunliu]

As mentioned in README, (also related to #534)

If you're running VS2019, you'll also need to install the "v141 Toolset" and "Visual C++ ATL for x86 and x64"

But actually v141 Toolset is not required in VS2019. The following are the configurations of my VS2019 and I can build the solution successfully.

C++ Desktop development

UWP development

Individual components

To build the solution in VS2019, you need to have:

• Windows 10 version 1903
• Windows 10 SDK (10.0.18362.0)
• VS2019 with C++ Desktop and UWP development workloads, as shown in the above screenshots

And retarget the solution to v142 platform and the latest Windows SDK.

[fcharlie]

git clone https://github.com/microsoft/Terminal.git
cd Terminal
git submodule init
git submodule update
nuget restore OpenConsole.sln
msbuild /p:Configuration=Release;AppxBundle=Always;AppxBundlePlatforms="x64" /p:Platform=x64 /p:PlatformToolset=v142 /p:TargetPlatformVersion=10.0.18362.0 /p:PreferredToolArchitecture=x64 OpenConsole.sln

[MarioLiebisch]

Consider the README instructions as minimal build environment requirements. And v142 > v141.

Might be, but it's still very misleading. If you have VS 2019, you don't need the v141 tools, because it should install either v141 or v142 by default anyway. My first impression was also that I'd have to install those, too.

[timheuer]

@chunliu consider renaming this issue to "Move to VS2019 and v142 toolset" to be more directed at what is proposed.

[jongio]

@fcharlie Did you run in Command Prompt for VS or cmd?

[timheuer]

@fcharlie Did you run in Command Prompt for VS or cmd?

If you run tools/razzle.cmd before what @fcharlie runs you can do it in cmd and not need the 'for VS' one (basically sets all the paths just in case)

[chunliu]

@timheuer if the source solution is moved to VS2019 and v142, people with VS2017 could have problem to build it as v142 toolset might not be installed on VS2017.

I think the proper way to address the building issue of VS2019 is to keep the source solution targeting on VS2017 and v141 toolset, but include the proper instructions for VS2019 and v142 toolset in README. The team can retarget the source solution when they don't need to support VS2017 anymore.

[chunliu]

@jongio I tried it with VS2019 command prompt and it is working fine. You need to include the path .\dep\nuget\ for nuget command.

[snooopcatt]

git clone https://github.com/microsoft/Terminal.git
cd Terminal
git submodule init
git submodule update
nuget restore OpenConsole.sln
msbuild /p:Configuration=Release /p:Platform=x64 /p:PlatformToolset=v142 /p:TargetPlatformVersion=10.0.18362.0 /p:PreferredToolArchitecture=x64 OpenConsole.sln

this worked, but how do I deploy? OpenConsole.exe starts old console

[fcharlie]

@snooopcatt My notebook is too old, I have not tried how to package and deploy it on the command line.

[chunliu]

@snooopcatt the easiest way is to package or deploy it with Visual Studio.

[chunliu]

@snooopcatt there is a PowerShell script in build/scripts/Create-AppxBundle.ps1. I didn't try it, but maybe you can use it to package the app from command line.

[12101111]

I have thousands of "error MIDL2003: [msg]redefinition [context]".
I 'm using VS 2019, v142 and SDK 10.0.18362

I can build it using SDK 10.0.17663 and v142

[Tuumke]

git clone https://github.com/microsoft/Terminal.git
cd Terminal
git submodule init
git submodule update
nuget restore OpenConsole.sln
msbuild /p:Configuration=Release /p:Platform=x64 /p:PlatformToolset=v142 /p:TargetPlatformVersion=10.0.18362.0 /p:PreferredToolArchitecture=x64 OpenConsole.sln

this worked, but how do I deploy? OpenConsole.exe starts old console

Don't you need to press CTRL+T to start a new tab?

[YYYGH]

I have a error MIDL2011 [msg]unresolved type declaration [context]: Windows.UI.Xaml.Markup.IXamlMetadataProvider [ RuntimeClass 'TerminalApp.XamlMetaDataProvider' ] TerminalApp F:\GitHub\Terminal\src\cascadia\TerminalApp\x64\Release\XamlMetaDataProvider.idl 6

[chunliu]

@YYYGH and @12101111 Did you retarget the solution to the latest Windows SDK and v142 platform in Visual Studio?

[YYYGH]

@YYYGH and @12101111 Did you retarget the solution to the latest Windows SDK and v142 platform in Visual Studio?

thank you! I renew the solution config and is build success.

but can't run WindowsTerminal.exe, is no reaction.
windows 10 version: 1803

[chunliu]

@YYYGH to run it, you need Windows 10 1903 with Developer mode on. Then you can right click the solution in VS and choose Deploy Solution.

[YYYGH]

@YYYGH to run it, you need Windows 10 1903 with Developer mode on. Then you can right click the solution in VS and choose Deploy Solution.

Thanks very much!

[JushPush]

git clone https://github.com/microsoft/Terminal.git
cd Terminal
git submodule init
git submodule update
nuget restore OpenConsole.sln
msbuild /p:Configuration=Release /p:Platform=x64 /p:PlatformToolset=v142 /p:TargetPlatformVersion=10.0.18362.0 /p:PreferredToolArchitecture=x64 OpenConsole.sln

Thanks!

[Backer-Sultan]

I'm not able to deploy the WindowsTerminal. I'm getting the following error telling me that the deployment target should be running on 10.0.18362.0 or higher

Though, in the project settings, the target SDK is 10.0.17763

And I'm sure that my Windows is running that version.

I'm not sure where is the error coming from!

[MarioLiebisch]

@Backer-Sultan The error message is correct. It's not just an SDK thing (the "target" you select). It's also a functionality thing. You'll need Windows 10 version 1903 (i.e. the May 2019 update) for this to be deployable and functional.

[Backer-Sultan]

@Backer-Sultan The error message is correct. It's not just an SDK thing (the "target" you select). It's also a functionality thing. You'll need Windows 10 version 1903 (i.e. the May 2019 update) for this to be deployable and functional.

Thank you for the clarification! The May 2019 update is still not available for me for some reason. I will try to manually install it.

[MarioLiebisch]

@Backer-Sultan As far as I know it's only on MSDN so far, not yet on Windows Update (think that will follow some time within the next 2 or 3 weeks).

[chunliu]

@thenecroscope after you deploy the solution, you should see Windows Terminal (Preview) in Start menu. You can launch the terminal from there.

[ksawerykarwacki]

@ksawerykarwacki I switched to building from VS after those warnings and everything builded and started. One misleading thing was lack of tabs which were hidden by default.

[mKay00]

Here on github under issues is the best place for feature requests, bugs, etc.
Keyboard shortcuts will be remappable soon and you can find and change them in the profiles.json #748

[valen214]

git clone https://github.com/microsoft/Terminal.git
cd Terminal
git submodule init
git submodule update
nuget restore OpenConsole.sln
msbuild /p:Configuration=Release;AppxBundle=Always;AppxBundlePlatforms="x64" /p:Platform=x64 /p:PlatformToolset=v142 /p:TargetPlatformVersion=10.0.18362.0 /p:PreferredToolArchitecture=x64 OpenConsole.sln

I have to add /p:OutputPath=<project directory>\bin to mitigate some error.

[miniksa]

Current issues delaying completion of this:

• The internal build lab required for signing packages does not yet support Visual Studio 2019, 14.2, nor the 1903 SDK (10.0.18362).

  • Mail has been sent to the lab onboarding team asking for support and an ETA

• The alternative of using a multi-phase build (use public Hosted 2019 pool for build, use internal pool for signing) is a possibility, but...

  • We would need to have something that sets up the versioning resources for us. This is currently done by an internal-only pool support task. We would need to identify and implement a public task to set up the version during the compilation phase on the Hosted 2019 pool and then send the artifacts to the internal 2017 pool for signing dispatch and symbol registration

• A final alternative recommendation was given to us by the lab build team: try to nuget-fetch the build tools required onto the 2017 machine.

  • I tried this and it sat for 6+ minutes going nowhere and I presume it will time out. Reliability/performance of this is too bad for me to consider further.

• I will upload a draft PR with the version number changes. It works fine in VS2019 with the version number changes. Also, as of my tests today thanks to the .vsconfig file, VS2019 can build it just fine (after resolving dependencies automatically/installing them). So can VS2017.

[miniksa]

More stuff we're stuck on:

• Hosted agents don't have the 18362 SDK installed yet. I've linked the discussion on adding them and related PRs from the Azure Agents repository in the PR move version to vs2019, the 1903 sdk, and the 14.2 build tools. #1012.

[fcrick]

I have thousands of "error MIDL2003: [msg]redefinition [context]".
I 'm using VS 2019, v142 and SDK 10.0.18362
I can build it using SDK 10.0.17663 and v142

@12101111 I hit this. Doing Clean Solution and building again made it go away.