Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying a font to be used in profile that does not exist causes the app the crash #550

Closed
nshanny opened this issue May 8, 2019 · 3 comments · Fixed by #2153
Closed
Assignees
Labels
Area-Fonts Related to the font Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Milestone

Comments

@nshanny
Copy link

nshanny commented May 8, 2019

I added a new profile to the profiles.json specifying a font that is not installed on my system. When attempting to start the profile the app crashes with the following:

The program '[15980] WindowsTerminal.exe' has exited with code -1073741819 (0xc0000005) 'Access violation'.

Specifying a font that is installed causes the problem to not occur.

The profile definition looks like this:

    {
      "guid": "{e2f9d7d6-369b-4841-9429-61f5b38474cf}",
      "name": "Bash",
      "colorscheme": "Campbell",
      "historySize": 9001,
      "snapOnInput": true,
      "cursorColor": "#FFFFFF",
      "cursorShape": "bar",
      "commandline": "bash.exe",
      "fontFace": "Fira Code",
      "fontSize": 12,
      "acrylicOpacity": 0.5,
      "useAcrylic": false,
      "closeOnExit": true,
      "padding": "0, 0, 0, 0"
    }

@DHowett-MSFT DHowett-MSFT added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Fonts Related to the font and removed Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues labels May 8, 2019
@zadjii-msft zadjii-msft added this to the Windows Terminal v1.0 milestone May 8, 2019
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@ryzngard
Copy link
Member

Similar to this, specifying a large font name seems to crash as well. I used "Ubuntu Mono derivative Powerline" and it crashes, although the font is installed.

@DHowett-MSFT
Copy link
Contributor

That one is #602.

@miniksa miniksa self-assigned this Jul 30, 2019
@ghost ghost added the In-PR This issue has a related PR label Jul 30, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 30, 2019
@miniksa miniksa removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 30, 2019
@ghost
Copy link

ghost commented Aug 3, 2019

🎉This issue was addressed in #2153, which has now been successfully released as Windows Terminal Preview v0.3.2142.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Fonts Related to the font Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants