Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when running fzf via SSH in Git Bash #5166

Closed
glen-84 opened this issue Mar 29, 2020 · 2 comments
Closed

Issue when running fzf via SSH in Git Bash #5166

glen-84 opened this issue Mar 29, 2020 · 2 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Resolution-External For issues that are outside this codebase

Comments

@glen-84
Copy link

glen-84 commented Mar 29, 2020

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 0.10.781.0

Any other software?

Git for Windows: 2.26.0

Steps to reproduce

  1. Create a profile with the commandline: %PROGRAMFILES%/Git/bin/bash.exe -li.
  2. SSH into a Debian64 machine (I'm using VirtualBox).
  3. Run fzf.

Expected behavior

Proper output/rendering.

Actual behavior

When I run where ssh, there are 2 SSH binaries:

  • C:\Program Files\Git\usr\bin\ssh.exe (OpenSSH_8.2p1, OpenSSL 1.1.1e 17 Mar 2020)
  • C:\Windows\System32\OpenSSH\ssh.exe (OpenSSH_for_Windows_7.7p1, LibreSSL 2.6.5)
  1. Using the first (which is the default), fzf is completely broken. See screenshot 1 below.
  2. Using the second, fzf appears to work correctly.

Why do they differ? Is there a bug with Git for Windows' SSH binary?

  • Inside the VM:
    • TERM: cygwin
    • LANG: en_ZA.UTF-8
    • LC_ALL: ``

fzf

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 29, 2020
@DHowett-MSFT
Copy link
Contributor

If you set TERM to xterm-256color before running fzf, does it work better? (I imagine it doesn’t.)

Even so- Cygwin, before version 3.1 (which git for Windows hasn’t yet updated to), thinks it’s smarter than the windows console and translates all incoming VT sequences back into Win32 API calls. It doesn’t do a very good job of this.

The problem is, conhost has been able to parse VT for the better part of five years now.

Win32-OpenSSH has no such translation.

Closing as external in the meantime :)

@DHowett-MSFT DHowett-MSFT added Resolution-External For issues that are outside this codebase and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 29, 2020
@glen-84
Copy link
Author

glen-84 commented Mar 29, 2020

If you set TERM to xterm-256color before running fzf, does it work better? (I imagine it doesn’t.)

It behaves differently, but it's still broken.

Even so- Cygwin, before version 3.1 (which git for Windows hasn’t yet updated to) ...

Thanks for the explanation. So do you think that this is likely to be fixed when Cygwin is updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Resolution-External For issues that are outside this codebase
Projects
None yet
Development

No branches or pull requests

2 participants