Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Tab doesn't duplicate split panes #4674

Open
keithn opened this issue Feb 21, 2020 · 6 comments
Open

Duplicate Tab doesn't duplicate split panes #4674

keithn opened this issue Feb 21, 2020 · 6 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@keithn
Copy link

keithn commented Feb 21, 2020

Steps to reproduce

Create some spit panes in a tab, then ctrl-shift-d to duplicateTab, new tab is a single pane tab.

Expected behavior

new tab is a duplicate of the split paned tab with the same panes

Actual behavior

single pane tab

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 21, 2020
@zadjii-msft
Copy link
Member

I don't hate the idea of adding a setting to the "newTab" ShortcutAction to enable duplicating panes as well. Thanks for the suggestion!

Something like:

{ "command": { "action": "newTab", "duplicatePanes": true }, "keys": ["ctrl+shift+d"] },

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Feb 21, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 21, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Feb 21, 2020
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Feb 21, 2020
@DHowett-MSFT
Copy link
Contributor

I honestly wonder if duplicating a tab should simply always duplicate its panes. After all, not doing so (and terminal randomly selecting one of the panes under the tab) could be viewed as simply incorrect...

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 21, 2020
@DHowett-MSFT
Copy link
Contributor

Yanking triage in any case: this is a good backlog item, but if somebody wants to work on it we can pull it ahead.

@Don-Vito
Copy link
Contributor

@DHowett-MSFT - I did some short implementation of panes duplication (that almost works, besides setting the focus in the same pane, that I simply cannot get working), but I am just wondering how useful it is when the panes are created in the initial state (e.g. default directory).

@zadjii-msft
Copy link
Member

Maybe it's valuable to do even without the path preservation now, so that when #3158 / #8166 / whatever it ends up being does land, then the path duplication will just start working for duplicated tabs as well.

Personally, I'm the kind of user where I set up each profile's startingDirectory to the root of a project, and typically I stay in the root of each project, so duplicating a bunch of panes that are all in that directory already doesn't seem like a bad thing to me ☺️

@Don-Vito
Copy link
Contributor

Don-Vito commented Nov 9, 2020

@zadjii-msft - I will try to push it then.. hopefully this week / weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

5 participants
@keithn @Don-Vito @DHowett-MSFT @zadjii-msft and others