-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How Do I Build it to Begin With? #461
Comments
The Readme has a section for that |
There are some instructions on how to get started on the repo readme file, but some prerequisites (which version of Windows, Visual Studio, what do I need enabled of SDKs and whatnot) would be nice. |
Same. ========== Build: 18 succeeded, 24 failed, 0 up-to-date, 0 skipped ========== |
Thanks @lizy14 . I tried that, but got this error:
However windows says that I am up to date, so I don't know how to get |
@will I'm in Windows Insider Program (Release Preview ring), so I'm on 18362. It seems that if you want to run it you need 1903. |
Ah thank you! Fixed those. 3 of these: 1 of these: (I think the latter because of the 3 former errors). |
same error,bull shit |
any built exe download? |
winrt I think needs the Windows Insider 10.0.18362.* build. But so far, seems to almost compile by just importing the solution into Visual Studio and upgrading it to the 2019/v142 library tools (have to install the v142 tools from the Visual Studio Installer > Individual Components, but I think they're default with 2019 anyway). Before this worked I also ran these commands in the README: I also ran tools/razzle.bat, after changing the MSBuild path their to the 2019 location of MSBuild.exe
...but not sure that's necessary if importing to VS2019 and building from there. Just listing what I did. Then I imported the project to VS2019, make sure Configuration is set to x64, cleaned it, and built it. |
Guys I think that worked. I didn't need the Insider build (was not finished installing yet), but I did need to install the WinRT package: ========== Rebuild All: 47 succeeded, 0 failed, 0 skipped ========== However, the built x64/Debug WindowsTerminal.exe file throws an error upon trying to run it: Humbugh. |
Running Debug on the WindowsTerminal (Windows Store 10 version) from within VS2019 throws exception here: Exception thrown at 0x00007FFA64CE9129 in WindowsTerminal.exe: Microsoft C++ exception: winrt::hresult_error at memory location 0x000000A58C91F2F8. occurred inside base.h line 4321. So, very esoteric error there, related to WinRT, if anyone has any ideas. I am not a C++/desktop developer (web mostly). I'm gonna finish installing Insider build (another 10 mins), restart, see what happens. |
None of the suggestions in here have allowed me to build it. Please provide build instructions for VS2019. Much appreciated |
#449 should fix some issues with VS2019 not working, some other fixes are also in here |
Chloe follow #449 for the first fix to remove all the syntax errors, it's easy, literally just this change: Second, open the project in VS2019, and right click solution, select Retarget solution, and change it to VS2019, x64, etc. Try to build it and see what errors it's giving, and let us know. That helps. If you get the winrt/TerminalApp.h errors, install the WinRT C++ library as above. I'm able to compile on Windows 10 VS2019 without errors, but it will not run. |
@will Are you saying you got the WindowsTerminal app to run? Am still waiting for Insider build 18362 to finish installing. |
@W3iss it does seem to be a windows insider requirement just see if it will work when insider is done, I unfortunately haven't had time to test everything yet but hopefully when I do we can make a proper list of fixes. |
@will @DimitriLambrou Cool, thanks! Will give it another go here in a bit. |
@will @Supernalboot Got it! Debugging it doesn't work, have to actually right click the solution and Deploy, as @will implied, then it will show in start menu. Thanks. Everyone else, just follow the few steps previously mentioned above and it should work. |
Steps:
If you get an error like this @rw3iss Nice work. |
why nobody publish zip or exe file? |
Because you can't. Running the built .exe crashes. It only works if you choose 'Deploy Solution' in VS2019, then it automatically shows up in your start menu. I don't know why. |
because a UWP app can't run standalone. It's not a win32 app |
installed the Microsoft.Windows.CppWinRT nuget Package via VS 2019 Community Any possible solutions? |
@Paul-Weissner I installed winrt from the standalone exe linked above. Maybe try that after uninstalling from vs/nuget/windows first. |
Yea that's all it is, hah. Should have tab support though (ctrl+t) and also wsl and powershell baked in, and stuff. |
wow....Thank you! |
Ctrl+Tab - forward, Ctrl+Shift+Tab - back. |
I managed to build it is VS2019 without changing target to v142 and without any code change. Followed this to install WinRT and then right-clicked on solution -> install missing feature. |
@isaac2004 |
I'm going to close this issue, and route all discussion on the topic of getting the terminal to build to #489 |
@zadjii-msft look above, why am I not getting dropdown or settings? |
@isaac2004 Try pressing ctrl+t. The defaults intentionally look much like the old Console. We're still working on the UI, so be patient :) |
@isaac2004 FYI: you can change the profile.json (C:\Users{userName}\AppData\Local\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\RoamingState on my machine...) to have "alwaysShowTabs": true. This way when you open the terminal it will be clear you're working with the new windows terminal AND you'll have immediate access to the drop down. |
@ALL Fair warning: I installed Insider Build a day ago, got this all working, things were fine, nothing intense running, all the sudden the computer just gave me nonstop BSOD, and nothing worked, no system restores, couldn't boot into safemode. Only thing that worked was resetting pc and keeping files, but have to reinstall all software, grumble. Not really sure why it happened, but maybe related. |
I installed the WinRT packaged linked above and I still get the error: Severity Code Description Project File Line Suppression State |
Right click on solution and check if there is option to "Install Missing Features". This solved the error for me. |
@MrErikDev did you escape |
@MrErikDev and you miss a quotation mark in your second command in front of the C:.. |
Hey fellas, Can anybody help me how to start debugging?? |
Ideally, releases should contain an executable to test. I hate the fact that you have to use the Windows Store to install it. |
@wrathofodin because it's a modern application, you cannot run the exe file directly |
Okay I am very new to this whole building repository thing and I just really need to be told how to build the project. I have no clue where to start and I just need guidance.
The text was updated successfully, but these errors were encountered: