Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop files does not work in right/bottom areas with >100% DPI scaling #4567

Closed
jingyu9575 opened this issue Feb 13, 2020 · 2 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@jingyu9575
Copy link

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 0.9.433.0

Any other software?: No

Steps to reproduce

  1. In Windows display settings, select 150% DPI scaling;
  2. Drag a file to the terminal, at the bottom or right inside the window.

Expected behavior

Tooltip shows "copy path to file". The file path is inputed.

Actual behavior

Nothing. Tooltip shows "🚫". This screenshot was made with a CI build right after drag/drop was implemented, but the same behavior happens in today's release.

On my system with 150% DPI scaling, the size of the acceptable area seems to be 1/(150%) of the window (similar to #2606). Also, some bottom area in the tabs is (incorrectly) acceptable to drops, and the height seems to be also 1/(150%) of the tab bar. Therefore I suspect some code is checking the acceptable area but is missing a DPI/96 factor.

Screenshot

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 13, 2020
@DHowett-MSFT
Copy link
Contributor

This looks suspiciously like #2606... It looks like they both deal with xaml control hit-testing zones! So alike they are that I'm going to call this one a /dupe of #2606. 😄

Thanks for the report!

@ghost
Copy link

ghost commented Feb 14, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Feb 14, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 14, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants