Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Windows version in the about box #3616

Closed
teobugslayer opened this issue Nov 18, 2019 · 12 comments
Closed

Provide Windows version in the about box #3616

teobugslayer opened this issue Nov 18, 2019 · 12 comments
Assignees
@mkitzan
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.0

Comments

@teobugslayer
Copy link

Description of the new feature/enhancement

To simplify bug reporting, please provide the version you request from the community in one place.

I suggest adding the windows version in WT's About box and let the users easily copy/paste it in the GitHub issues.
@teobugslayer teobugslayer added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 18, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 18, 2019
@teobugslayer teobugslayer changed the title Provide Windows version ins about box Provide Windows version in the about box Nov 18, 2019
@zadjii-msft
Copy link
Member

This is actually something we've had in the terminal since the first public release...
image

/dup #867 #1196 #1335 #1452

@ghost
Copy link

ghost commented Nov 18, 2019

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 18, 2019
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 18, 2019
@DHowett-MSFT
Copy link
Contributor

This one actually looks like a request for the OS version, which does seem useful.

@DHowett-MSFT DHowett-MSFT reopened this Nov 18, 2019
@DHowett-MSFT DHowett-MSFT added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. labels Nov 18, 2019
@teobugslayer
Copy link
Author

Yep, I meant to ask to show the OS version, which is required to submit a Github issue. Just saving one annopying step in the process.

@mkitzan
Copy link
Contributor

mkitzan commented Nov 23, 2019

I'll look into an implementation for this

@mkitzan
Copy link
Contributor

mkitzan commented Nov 23, 2019 •
edited
Loading

What OS version formatting would be most helpful for the dev team so users could just copy-paste the text in their issue post?
Also, in my draft implementation I introduce a new private function to TerminalPage to handle getting the Windows version. The function seems out of place in TerminalPage though. CascadiaSettings might be a better location for this function considering it's a data member of TerminalPage. Any ideas of a better location for this function?
Here's the commit with the full implementation. Any feedback before the PR would be great!
in-progress

@zadjii-msft
Copy link
Member

@mkitzan Honestly that looks pretty good to me. I probably wouldn't even move the _GetWindowsVersion function, since the TerminalPage is generally responsible for building the rest of that dialog, I think it fits well there.

@zadjii-msft zadjii-msft removed the Help Wanted We encourage anyone to jump in on these. label Nov 25, 2019
@mkitzan
Copy link
Contributor

mkitzan commented Nov 25, 2019

Sounds good, I'll make a PR for this fix.

@mdtauk
Copy link

mdtauk commented Nov 25, 2019

Is the full build number needed, over say the 1909 versioning?

@DHowett-MSFT
Copy link
Contributor

@mdtauk since we are the windows console team, and the console subsystem is part of windows, and it can be serviced with an update I’m going to say yes absolutely

@mdtauk
Copy link

mdtauk commented Nov 25, 2019

@mdtauk since we are the windows console team, and the console subsystem is part of windows, and it can be serviced with an update I’m going to say yes absolutely

Good good! Perfect justification.

@mkitzan mkitzan mentioned this issue Nov 25, 2019
Closed
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Nov 25, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Dec 19, 2019
@ghost ghost removed the In-PR This issue has a related PR label Jan 15, 2020
@zadjii-msft
Copy link
Member

Hey there's a really long conversation in #3696 about why we're not doing this. If anyone's interested in the reasons why, go read that PR. Thanks!

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkitzan mkitzan

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

About Dialog OS Version mkitzan/terminal
5 participants
@teobugslayer @mdtauk @DHowett-MSFT @zadjii-msft @mkitzan