Bug: When headless, GetLargestConsoleWindowSize reports a MUCH too small size

[jazzdelightsme]

Environment

ssh client: recent internal build of Windows
ssh server: recent internal build of Windows (WCOS)
vim: custom build that can load on the server

In a headless pseudoconsole session (such as over ssh), GetLargestConsoleWindowSize is reporting a maximum possible window size of 640 columns and 18 rows (on my particular SKU of Windows, which might differ from others). 640 columns isn't bad, I suppose, but 18 rows is downright tiny. I debugged a bit and found that internally (in conhost) this is due to a "screen" size in pixels of 640x300, and a font size of {1, 16}. (Of course there is not really a screen or pixels in a headless scenario, and that font size seems strange.)

Over ssh, I believe the console does not have any way to determine the ssh client's maximum possible window size (it doesn't know the size of the monitor the client is using, or the font being used, or even if it's a windows machine). It can be notified of window size changes on the client side (section 6.7: "Window Dimension Change Message" of RFC 4254), but not what the max possible size is. (Although I know very little about ssh; it's possible there's some extension or convention or something.)

So I propose that since there is no monitor hooked up to a headless session, GetLargestConsoleWindowSize should just report { SHRT_MAX, SHRT_MAX } (and let the client deal with whatever happens if the client sets the console's size too big).

(Without this, vim running in an ssh session is stuck at 18 lines high and cannot be made any bigger.)

[jazzdelightsme]

An alternate idea (floated by DHowett on an email) would be to limit GetLargestConsoleWindowSize to reporting just the values the pseudoconsole caller provides in Resize or on initialization so the connected client application never tries to break out.

The problem with that, as noted by DHowett, is "VT applications are allowed to resize their terminals..."

What that would mean for vim over sssh, for example, is that if you wanted to grow it (":set lines="), you'd have to exit vim, resize your console, then re-launch vim. But at least that would work.

[DHowett-MSFT]

I'm tagging this one up, but leaving Triage on so we discuss it on Monday. 😄

[DHowett-MSFT]

Current thoughts: for pseudoconsole hosts only, we can return {SHRT_MAX, SHRT_MAX} through the service locator. If not the service locator, all the API methods in "getset". We can't necessarily use the pty-requested size as the "maximum" because a few other console APIs that resize the buffer use ...Largest... as a bounds check.

[zadjii-msft]

Functions in discussion:

ApiRoutines::GetLargestConsoleWindowSizeImpl
SCREEN_INFORMATION::GetLargestWindowSizeInCharacters
IWindowMetrics::GetMaxClientRectInPixels