Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to reset zoom #2578

Closed
eyalroth opened this issue Aug 28, 2019 · 5 comments
Closed

Add an ability to reset zoom #2578

eyalroth opened this issue Aug 28, 2019 · 5 comments
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release

Comments

@eyalroth
Copy link

Description of the new feature/enhancement

Allow to reset the zoom (to 100%) after changing it with Ctrl + Mouse scroll. A keyboard shortcut -- say, Ctrl+0 -- would be enough to start with.

There is already an issue for this request, but it mainly addresses another bug.

@eyalroth eyalroth added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 28, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 28, 2019
@zadjii-msft
Copy link
Member

#300 more refers to the original conhost, so this isn't really a dupe.

This pairs nicely with #1142/#1349, for maybe setting the font size to a specific size, not just resetting it.

@zadjii-msft zadjii-msft added Area-Input Related to input processing (key presses, mouse, etc.) Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Aug 28, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 28, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Aug 28, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 29, 2019
@Jaykul
Copy link
Contributor

Jaykul commented Sep 17, 2019

Just a note: for now, you can somewhat work around this by triggering a settings reload.

E.g. by touching the file...

sp "~\AppData\Local\Packages\Microsoft.WindowsTerminal_*\LocalState\profiles.json" LastWriteTime (Get-Date)

@zoechi
Copy link

zoechi commented Dec 6, 2019

Ctrl+0 works for me.
It's weird though that ctrl+- zooms out, ctrl++ doesn't allow to zoom in.

I'm searching for a way to disable zooming at all.

This did it for ctrl+-, but I haven't found custom bindings for the mouse wheel.

 {
      "command": "unbound",
      "keys": [ "ctrl+-" ]
    },

@zadjii-msft
Copy link
Member

@zoechi for the record, the reason "increaseFontSize" is bound to Ctrl+= is that on a US keyboard layout, + is on the same key as =, but you need to hold shift to get the +. So typically, most applications has zoom in bound to Ctrl+= anyways, since it's silly to have zoom out bound to ctrl+key and zoom in bound to ctrl+shift+key


Goodness gracious, this was actually added in #3505, which was shipped in 0.7. Looks like we let #3319 exist without getting duped to this thread.

@zadjii-msft zadjii-msft removed this from the Terminal Backlog milestone Dec 6, 2019
@zadjii-msft zadjii-msft added the Resolution-Fix-Available It's available in an Insiders build or a release label Dec 6, 2019
@zoechi
Copy link

zoechi commented Dec 6, 2019

@zadjii-msft Thanks for the info. I wasn't aware of that because on German keyboards it's usually Ctrl++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Projects
None yet
Development

No branches or pull requests

5 participants