Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to copy on Enter key-press like classic console QuickEdit mode #2464

Closed
nguerrera opened this issue Aug 17, 2019 · 6 comments
Closed
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@nguerrera
Copy link

nguerrera commented Aug 17, 2019

Description of the new feature/enhancement

Going back many years, as long as QuickEdit mode was enabled, you could use the following workflow to copy/paste

  1. Make selection with mouse and left button
  2. Press Enter to Copy
  3. Right click to paste

I'm aware that step 2 can be done in both classic and new terminal using right click instead of Enter. I'm further aware that that is more efficient, but I was taught to press enter over a decade ago and I can't shake the muscle memory. I have been committing unfinished commands at step 2 and pasting prior junk like whole documents as commands at step 3 since adopting the new terminal. It would be great if there was a way to make it tolerate my sub-optimal technique. 😄

I would like an option to make Enter copy when I have a selection, just like right click does now.

@nguerrera nguerrera added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 17, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 17, 2019
@DHowett-MSFT
Copy link
Contributor

I have a feeling that now that #2446 is merged, this will just work if you add a key binding with command=copy keys=enter. Once we fix #2389, you can even keep it alongside ctrl+shift+c!

@nguerrera
Copy link
Author

@DHowett-MSFT Would I need to build from source to confirm that or is that already worth trying on what I got from the store?

@DHowett-MSFT
Copy link
Contributor

For that one, you'll need to build from source. Sorry about that! We're tracking for a new preview release "pretty soon," though.

@nguerrera
Copy link
Author

No worries at all! I'll wait a bit. Thanks!

@carlos-zamora
Copy link
Member

Just tested it on master and @DHowett-MSFT is correct! You'll have to add the following keybinding:

{
    "command": "copy",
    "keys": [
        "enter"
    ]
}

It's available if you build from master or in the next release. Thanks!

@nguerrera
Copy link
Author

Works like a charm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

3 participants