Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No tabs in fullscreen, focus mode or not #11130

Open
Firehawke opened this issue Sep 3, 2021 · 8 comments · May be fixed by #18171
Open

No tabs in fullscreen, focus mode or not #11130

Firehawke opened this issue Sep 3, 2021 · 8 comments · May be fixed by #18171
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@Firehawke
Copy link

Windows Terminal version (or Windows build number)

1.11.2421.0

Other Software

No response

Steps to reproduce

Use F11 to switch between full screen and windowed mode. In the latter, tabs appear fine. In the former, there are never tabs shown. Setting a keybind for focus toggle will only affect the windowed mode, and I cannot get tabs in full screen mode under any circumstances.

I've tried opening multiple tabs to make sure it wasn't a "auto-hide the tabs if there's only one session open" case.

Expected Behavior

I would expect full screen mode to honor the focus mode.

Actual Behavior

Focus mode is not honored and tabs will never appear in full screen mode.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 3, 2021
@zadjii-msft
Copy link
Member

I suppose I have this tracked as a bullet point in #3486, but not a top level issue. Congrats, this thread is now the "Add a setting to have tabs always visible in fullscreen mode" thread

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Sep 8, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 8, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Sep 8, 2021
@zadjii-msft zadjii-msft mentioned this issue Sep 8, 2021
Open
9 tasks
@Firehawke
Copy link
Author

That explains why I didn't find it when I did a search. If I'd known, I wouldn't have opened this issue. Feel free to close.

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 15, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@zadjii-msft zadjii-msft mentioned this issue Jul 18, 2022
Closed
@eduardonunesp
Copy link

Any chance to add the option to show tabs in full screen mode? would be nice to have that option to toggle on/off

@zadjii-msft
Copy link
Member

I mean, yea, there's a chance - someone just needs to write the code now 😉

@JaiganeshKumaran
Copy link

Any chance to add the option to show tabs in full screen mode? would be nice to have that option to toggle on/off

It would be better if the tabs show up when you hover over the top instead of having it always in full-screen mode.

@zadjii-msft
Copy link
Member

Wadda ya know, that's also on the backlog, see #5677

@zadjii-msft zadjii-msft moved this to Should be written in Terminal Walkthroughs Feb 6, 2023
@KaiStarkk
Copy link

+1 for always show tabs making it so that it always shows tabs

@GeekJosh GeekJosh linked a pull request Nov 9, 2024 that will close this issue
Open
4 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Nov 9, 2024
@GeekJosh
Copy link
Contributor

GeekJosh commented Nov 9, 2024

I've put together a PR for this feature:

The implementation adds a new global appearance setting, "showTabsFullscreen", which can be either true or false:

  • true will show tabs in fullscreen state, as long as there is more than one tab open (same behaviour as windowed state when "alwaysShowTabs" is false)
  • false does not show tabs in fullscreen state (same as the current behaviour)
  • min/max/close controls are hidden when in fullscreen state

I really like @JaiganeshKumaran's idea to have the option of showing tabs on hover, but as the XAML TabView component doesn't currently support that natively (proposal for that here: microsoft/microsoft-ui-xaml#7202), it felt like a bigger change than just enabling the tab bar to show in full screen so thought it would be best to start with the simpler option. I'm happy to look in to adding that to this PR, or opening a new PR later for that if that would be the preferred implementation though.

Here's the PR: #18171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
Terminal Walkthroughs
Status: Should be written
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add the ability to show the tab bar in fullscreen GeekJosh/microsoft-terminal
7 participants
@DHowett @eduardonunesp @GeekJosh @KaiStarkk @zadjii-msft @Firehawke @JaiganeshKumaran