Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In tmux 3.4, ZSH does not work correctly either locally or by SSH #18154

Open
marovira opened this issue Nov 5, 2024 · 4 comments
Open

In tmux 3.4, ZSH does not work correctly either locally or by SSH #18154

marovira opened this issue Nov 5, 2024 · 4 comments
Labels
Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.

Comments

@marovira
Copy link

marovira commented Nov 5, 2024

Windows Terminal version

1.22.2912.0

Windows build number

10.0.22631.4391

Other Software

  • Git for Windows 2.47.0.windows.2
  • zsh 5.9
  • tmux 3.4
  • OpenSSH_9.9p1, OpenSSL 3.2.3 3 Sep 2024

Steps to reproduce

There are two issues that appear related as they are rendering problems that only occur when using ZSH. In order to reproduce the issues, either of the following is required:

  • A Git bash installation with ZSH
  • Connecting to a remote Linux server through SSH (via Git Bash) that is running ZSH.

Issue 1 Steps

  1. Start a terminal with ZSH using either of the aforementioned setups.
  2. Start typing any command. Longer commands will display the issue more clearly.
  3. Delete the command.

Issue 2 Steps

This specific issue only occurs on Linux servers with tmux and ZSH:

  1. Connect to a server using SSH. The terminal must be ZSH.
  2. Open tmux
  3. Open a new vertical split.
  4. Switch to the right-side split and enter any command.
  5. Now switch back to the original split and enter a different command.

Note

The flickering issue is not present in version 1.18.10301. The tmux issue however is present on any version since.

Expected Behavior

For both issues, the terminal should render the text correctly and the cursor should not flicker.

Actual Behavior

Issue 1

When entering or deleting text, the cursor jumps to the beginning of the current line and then back to the end rapidly. This is easier to see when deleting a command. Unfortunately it appears that screen recording doesn't showcase the issue properly so I can't show it.

Issue 2

Image
See that the ~/Documents > should've appeared on the right pane, and there's a gap on the right side before the cursor where ~/Documents should've appeared.

@marovira marovira added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 5, 2024
@marovira
Copy link
Author

marovira commented Nov 6, 2024

Extra info: the tmux issue just started happening recently. I'm not entirely sure what triggered it, but it wasn't happening earlier this year.

@carlos-zamora
Copy link
Member

Thanks for filing! Issue 1 is actually being tracked over in #6217. We'll still use this issue to track the second one you mentioned.

Extra info: the tmux issue just started happening recently. I'm not entirely sure what triggered it, but it wasn't happening earlier this year.

Have you updated tmux in the past year?

@carlos-zamora carlos-zamora changed the title ZSH does not work correctly either locally or by SSH In tmux 3.4, ZSH does not work correctly either locally or by SSH Nov 13, 2024
@carlos-zamora carlos-zamora added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. labels Nov 13, 2024
@marovira
Copy link
Author

Thanks for filing! Issue 1 is actually being tracked over in #6217. We'll still use this issue to track the second one you mentioned.

Extra info: the tmux issue just started happening recently. I'm not entirely sure what triggered it, but it wasn't happening earlier this year.

Have you updated tmux in the past year?

Good to know the first issue has been reported, thanks!

As for updating tmux, yes I have updated it a few months ago when I did a system update on my linux servers. I believe the issue only started occurring recently, but it may be that I just noticed it recently.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 13, 2024
@marovira
Copy link
Author

marovira commented Nov 13, 2024

This may or may not be related, but it appears that Terminal isn't rendering correctly whenever a program opens up multiple splits. Here's another case that looks similar:

  1. Connect to a server using SSH. Choice of terminal doesn't matter (issue occurs with both bash and zsh)
  2. Open a file in Vim.
  3. Now type :vert sb to open that same file in a new vertical split.
  4. Switch to the right-hand split and close it using :q

See that the terminal isn't rendered correctly. Here's an example
Before closing the split:
Image
After closing the split:
Image

Note that this issue can seemingly only be reproduced when the Terminal is maximised. It doesn't seem to happen on a smaller window.
The text can be recovered if you move the cursor through the missing lines, forcing it to re-render.

@carlos-zamora carlos-zamora added this to the Terminal v1.23 milestone Nov 20, 2024
@carlos-zamora carlos-zamora added Help Wanted We encourage anyone to jump in on these. Priority-3 A description (P3) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Attention The core contributors need to come back around and look at this ASAP. labels Nov 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants