Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings are always saved with command id #18111

Open
ebarzilay-godaddy opened this issue Oct 26, 2024 · 1 comment
Open

Settings are always saved with command id #18111

ebarzilay-godaddy opened this issue Oct 26, 2024 · 1 comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements

Comments

@ebarzilay-godaddy
Copy link

Windows Terminal version

1.21.2911.0

Windows build number

10.0.22631.4317

Other Software

No response

Steps to reproduce

Making any modification to the settings and saving them adds an id field to all actions.

I don't use these IDs yet, and even when I do, then not for all of my actions.

This sounds harmless, but the annoying thing is related to #18110 -- I have a lot of sendInput actions (mapping obscure key combos to escape sequences which my environment knows about), and I'm forced to add useless IDs to all of them.

Looks like they're optional -- BUT -- if I drop them, then next time Terminal rewrites my settings, it blesses me with a fresh layer of IDs, and I now need to check the differences and re-remove them. Since this is tedious and error prone, I'm effectively forced to accept this and add IDs. Life becomes unnecessarily more verbose with IDs that I'll never need.

Expected Behavior

No IDs added for actions unless I already had an id for them.

Actual Behavior

IDs are always added.

@ebarzilay-godaddy ebarzilay-godaddy added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 26, 2024
@carlos-zamora carlos-zamora added the Needs-Discussion Something that requires a team discussion before we can proceed label Oct 30, 2024
@lhecker
Copy link
Member

lhecker commented Nov 18, 2024

We know that this worsens the situation around #18110 and we're hoping to possibly remedy that in the future. To explain, if the settings model was a database, our intention was to "normalize" it, as we wanted multiple key bindings to be able to refer to the same action. In a sense, the action ID we're adding is a foreign key. For what it's worth, you can use arbitrary IDs that you choose yourself.

@carlos-zamora carlos-zamora added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Discussion Something that requires a team discussion before we can proceed labels Nov 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements
Projects
None yet
Development

No branches or pull requests

3 participants