Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display more info for WinGet suggestions #17755

Open
3 tasks
carlos-zamora opened this issue Aug 20, 2024 · 0 comments
Open
3 tasks

Display more info for WinGet suggestions #17755

carlos-zamora opened this issue Aug 20, 2024 · 0 comments
Labels
Area-Suggestions Anything related to tasks or the suggestions UI (sxnui) Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.

Comments

@carlos-zamora
Copy link
Member

okay a minor thought: In 1.22 I added Description's to Commands. If the package catalog gives us a description, we could totally stick that in the teaching tip 👀

Similarly, IMO, we don't need --source winget in the Name of the Command. It's clearer to just say winget install Foo and have the rest of the args in the preview text (but that's just my opinion)

from #17614 (review)

Implementation

Should be pretty straightforward to do, but we need to make a few changes to make this happen:

  • Currently, ControlCore stores the suggestions as an IVector<hstring>. We'll need to change that to be able to hold the winget metadata (package description and simplified package name)
  • TerminalPage::_PopulateQuickFixMenu needs to be updated to display the metadata
  • TerminalPage::_doHandleSuggestions needs to be updated to display the metadata
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-Suggestions Anything related to tasks or the suggestions UI (sxnui) labels Aug 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 20, 2024
@carlos-zamora carlos-zamora removed Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Aug 21, 2024
@carlos-zamora carlos-zamora added this to the Terminal v1.23 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Suggestions Anything related to tasks or the suggestions UI (sxnui) Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

1 participant