Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AtlasEngine renders corner brackets at the left of the two-character space. #16656

Open
pandaninjas opened this issue Feb 2, 2024 · 1 comment
Labels
Area-AtlasEngine Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.

Comments

@pandaninjas
Copy link

pandaninjas commented Feb 2, 2024

Windows Terminal version

1.19.10292.0

Windows build number

10.0.22621.3007

Other Software

No response

Steps to reproduce

Type or enter characters containing left and right corner brackets

Expected Behavior

Corner brackets are aligned to the middle of the 2-character space, which was the case when using the old renderer. See attachments:
image
image
image

Actual Behavior

Corner brackets are aligned to the left of the 2-character space. See attachments:
image
image
image

@pandaninjas pandaninjas added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 2, 2024
@pandaninjas pandaninjas changed the title AtlasRenderer renders corner brackets at the left of the two-character space. AtlasEngine renders corner brackets at the left of the two-character space. Feb 2, 2024
@lhecker lhecker added Product-Terminal The new Windows Terminal. Priority-3 A description (P3) Area-AtlasEngine and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Tag-Fix Doesn't match tag requirements labels Feb 5, 2024
@lhecker lhecker added this to the Terminal v1.21 milestone Feb 5, 2024
@lhecker
Copy link
Member

lhecker commented May 1, 2024

I won't be able to fix this in time for 1.21. However, the only reason this bug occurs is because your Japanese font is proportional and not monospace (it's Yu Gothic). 1.21 on the other hand will allow you to customize your font fallback, which allows you to use MS Gothic or some other proper monospace Japanese font:

image

(You can try it out by installing our canary version: https://aka.ms/terminal-canary-installer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AtlasEngine Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants