Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startupActions not run when in elevated window #13929

Open
svict4 opened this issue Sep 6, 2022 · 1 comment
Open

startupActions not run when in elevated window #13929

svict4 opened this issue Sep 6, 2022 · 1 comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone

Comments

@svict4
Copy link

svict4 commented Sep 6, 2022

Windows Terminal version

4.14.2282.0

Windows build number

10.0.22000.0

Other Software

No response

Steps to reproduce

  1. Add a startupAction in the settings.json at the top level
{
  "$help": "https://aka.ms/terminal-documentation",
  "startupActions": "new-tab; new-tab",
  ...
}
  1. Add the elevate property to a profile, such as the defaults profile
...
  "profiles": {
    "defaults": {
      "colorScheme": "Tango Dark",
      "elevate": true,
      ...
    },
    "list": [ ... ]
  }
...
  1. See that the startupActions are not respected.
  2. See that by commenting/removing the elevate property, that it runs the startupActions

Expected Behavior

That the arguments in startupActions are run, even in elevated window

Actual Behavior

startupActions are ignored/not run

@svict4 svict4 added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Sep 6, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 6, 2022
@svict4 svict4 changed the title startupActions not run when elevate startupActions not run when run in elevated window Sep 6, 2022
@svict4 svict4 changed the title startupActions not run when run in elevated window startupActions not run when in elevated window Sep 6, 2022
@zadjii-msft
Copy link
Member

We'll need to come up with a proper design for this.

Opening an elevated "Foo" profile triggering the creation of a elevated window isn't going to hit startupActions ever. In that case, the "startup actions" has been effectively replaced by a single action - "open a tab with Foo".

  • Maybe we need an "open elevated window" action, that just opens wt without any actions. That would default to just startupActions.
  • Maybe we need a separate elevatedStartup for actions to run on startup of an elevated window. These would then be different from startupActions.
  • There's also The Terminal needs a commandline argument to open the window elevated #12191 - that could be combined with the command palette's commandline mode for a --elevate nt ; sp command to run specific actions in an elevated window.

@zadjii-msft zadjii-msft added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. and removed Issue-Bug It either shouldn't be doing this or needs an investigation. labels Nov 7, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 7, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Nov 7, 2022
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants