Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly displayed ANSI escape code ESC[40m #13513

Closed
ilyachalov opened this issue Jul 15, 2022 · 3 comments
Closed

Incorrectly displayed ANSI escape code ESC[40m #13513

ilyachalov opened this issue Jul 15, 2022 · 3 comments
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Resolution-Answered Related to questions that have been answered

Comments

@ilyachalov
Copy link

Windows Terminal version

1.13.11431.0

Windows build number

10.0.19043.0

Other Software

PowerShell 7.2.5

Steps to reproduce

Enter the command in 'PowerShell':

> "`e[30;40mtest`e[0m"

Expected Behavior

ANSI escape codes ESC[30m and ESC[40m is ANSI color 'Black'. It should be the same color, so there should be NO visible text in color ESC[30m on background ESC[40m.

It is said about it here:
https://en.wikipedia.org/wiki/ANSI_escape_code#SGR_(Select_Graphic_Rendition)_parameters

Actual Behavior

The text of color ESC[30m is visible on background ESC[40m:

test-in-powershell-wt

In the color scheme ('Campbell Powershell'):

color-scheme-campbell-powershell
@ilyachalov ilyachalov added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 15, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 15, 2022
@zadjii-msft
Copy link
Member

I'm pretty sure you're running in to the issue described in #6810, tracked originally in #6807, and ultimately fixed by #13352 in Preview v1.15.186

@ilyachalov
Copy link
Author

@zadjii-msft You're right.

I installed 'Windows Terminal Preview', version: 1.15.1862.0. Everything looks correct there:

campbell-powershell-ok

Also everything is correct for the code ESC[37;47m.

Good job!

As I understand it, this correction will appear in the next stable version?

@DHowett
Copy link
Member

DHowett commented Jul 15, 2022

As I understand it, this correction will appear in the next stable version?

Indeed! :)

@DHowett DHowett closed this as completed Jul 15, 2022
@DHowett DHowett added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered and removed Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 15, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Resolution-Answered Related to questions that have been answered
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DHowett @zadjii-msft @ilyachalov