Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property intenseTextStyle is not allowed #11629

Closed
KunalTanwar opened this issue Oct 27, 2021 · 3 comments
Closed

Property intenseTextStyle is not allowed #11629

KunalTanwar opened this issue Oct 27, 2021 · 3 comments
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity.

Comments

@KunalTanwar
Copy link

KunalTanwar commented Oct 27, 2021

Windows Terminal version (or Windows build number)

Windows Build Number 10.0.19043
Windows Terminal Version 1.10.2714.0

Other Software

No response

Steps to reproduce

  1. Open settings.json of the Terminal.
  2. And add "intenseTextStyle" in settings.
  3. You will see the warning "Property intenseTextStyle is not allowed"

image

Expected Behavior

It should not raise warning because it is a valid property.

Actual Behavior

It is telling that intenseTextStyle is not a valid property.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 27, 2021
@zadjii-msft
Copy link
Member

I didn't think that intenseTextStyle was in 1.10. It's in the https://github.com/microsoft/terminal/releases/tag/v1.11.2421.0 release notes, but #10759 suggests it's in 1.10?

Where are you putting that in the file? It is in the schema:

"intenseTextStyle": {
"default": "bright",
"description": "Controls how 'intense' text is rendered. Values are \"bold\", \"bright\", \"all\" and \"none\"",
"enum": [
"none",
"bold",
"bright",
"all"
],
"type": "string"
},

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Oct 27, 2021
@DHowett
Copy link
Member

DHowett commented Oct 27, 2021

We may have missed it out in the 1.10 schema.

@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Nov 3, 2021
@ghost
Copy link

ghost commented Nov 3, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity.
Projects
None yet
Development

No branches or pull requests

3 participants