Keybinding editor could be clearer

[elsaco]

Windows Terminal version (or Windows build number)

Windows Terminal Preview Version: 1.11.2421.0

Other Software

No response

Steps to reproduce

• open terminal settings
• in "Actions" add a new command

Expected Behavior

• new command edit working

Actual Behavior

new command edit not working

This is an example trying to add the first drop-down option "Break into the debugger". The intended key cord was "alt+shift+b". Notice how "a", "l", "t" are echoed in the entry box, then when trying to add "+" it just show "shift+plus":

command_action_edit.mp4

[zadjii-msft]

Ah okay I see what's going on here. That's not a text entry field, you're supposed to just press the key chord you want to bind. So as you're typing alt, it's showing those keys one at a time. I think we've got an open issue already for making that more clear - something @carlos-zamora can link if he likes.

[zadjii-msft]

I'm reopening this to track the discussion we had as a team:

• this box should automatically stop being in "edit mode" as soon as a non-modifier vkey is pressed
• When modifiers are pressed/released in edit mode, then the box should show ctrl+shift+, and update in realtime

that'll help make this clearer

[DHowett]

@lhecker and I had a discussion about this weeks ago, and I think we never filed an issue for it.

Thanks!