Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings]: Keyboard user is not able to switch between radio button using arrow/tab key throughout the app. #11159

Closed
Tracked by #9990
ghost opened this issue Sep 6, 2021 · 8 comments
Closed
Tracked by #9990

[Settings]: Keyboard user is not able to switch between radio button using arrow/tab key throughout the app. #11159

ghost opened this issue Sep 6, 2021 · 8 comments
Labels
A11ySev1 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility Area-Settings UI Anything specific to the SUI HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.12

Comments

@ghost
Copy link

ghost commented Sep 6, 2021 •
edited by ghost
Loading

Windows Terminal version (or Windows build number)

1.10.2383.0

Other Software

Test Environment:
OS: Windows 11 Version 21H2 (OS Build 22000.168)
Screen Reader: Narrator
Tool: Accessibility Insight for Windows

Steps to reproduce

Repro Steps:
Open Windows Terminal.
Open Settings page using "Ctrl + ',' ".
Verify that Keyboard user can switch between radio button using arrow/tab key throughout the app or not

User Experience: -> Priority 1
Keyboard users are impacted here as they will be unable to use different functionality as unable to switch between radio buttons.

Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/keyboard

Attachments:
Keyboard user is not able to switch between radio button using arrowtab key throughout the app..zip

Expected Behavior

Keyboard user should be able to switch between radio button using arrow key throughout the app.

Actual Behavior

Keyboard user is not able to switch between radio button using arrow/tab key throughout the app.

Observation: In Scan mode, Screen Reader user can switch between radio buttons.
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. Area-Settings UI Anything specific to the SUI Priority-1 A description (P1) labels Sep 7, 2021
@Priyanka-Chauhan123 Priyanka-Chauhan123 added A11ySev1 Accessibility tracking A11yWCAG Accessibility tracking HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking labels Sep 7, 2021
@zadjii-msft zadjii-msft added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 8, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.12 milestone Sep 9, 2021
@zadjii-msft
Copy link
Member

@v-rpundir We're already tracking this in #9566, which is tracking the upstream issue in microsoft/microsoft-ui-xaml#3156. We can't fix this ourselves, and will need to wait for WinUI to author a fix. Can we close this one?

@ghost
Copy link
Author

ghost commented Sep 15, 2021

Closing this bug as External as we are tracking this bug here microsoft/microsoft-ui-xaml#3156

@ghost ghost closed this as completed Sep 15, 2021
@zadjii-msft zadjii-msft mentioned this issue Jan 3, 2022
Open
12 tasks
@ghost ghost added the Tracking-External This bug isn't resolved, but it's following an external workitem. label May 2, 2022
@ghost
Copy link
Author

ghost commented May 2, 2022 •
edited by ghost
Loading

Issue is still repro on below environment.

Test Environment:
OS: Windows 11 Version 21H2 (OS Build 22598.200)
Application: Window Terminal Preview
App Version: 1.13.10984.0
Screen Reader: Narrator

@zadjii-msft
Copy link
Member

@v-rpundir I'm pretty sure we got rid of all the radio buttons in the Terminal. #12833 hasn't shipped to a release version yet, but 1.14 won't have any more radio buttons to worry about the upstream bug any longer.

@ghost ghost removed the Tracking-External This bug isn't resolved, but it's following an external workitem. label May 3, 2022
@ghost
Copy link
Author

ghost commented May 3, 2022 •
edited by ghost
Loading

Ok @zadjii-msft Will close this bug after checking on 1.14+ when these builds available our side. For now, we are keeping in open State for tracking purposes.

@ghost ghost reopened this May 3, 2022
@carlos-zamora carlos-zamora added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label May 19, 2022
@carlos-zamora
Copy link
Member

tagging as fix committed because (as Mike said) #12833 removed all the radio buttons so this issue should be closed in the next available update

@DHowett
Copy link
Member

DHowett commented May 26, 2022 •
edited
Loading

@v-rpundir this fix is now available in version 1.13 in the Windows Insider program, or for download on this page: https://github.com/microsoft/terminal/releases/tag/v1.13.11431.0

@ghost
Copy link
Author

ghost commented May 27, 2022 •
edited by ghost
Loading

Closing as fixed as not repro now on Version: 1.13.11432.0

@ghost ghost closed this as completed May 27, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11ySev1 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility Area-Settings UI Anything specific to the SUI HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.12
Development

No branches or pull requests
4 participants
@DHowett @carlos-zamora @zadjii-msft @Priyanka-Chauhan123