Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Shift+W doesn't work if Ctrl key is remapped. #11148

Open
kasajian opened this issue Sep 5, 2021 · 6 comments
Open

Ctrl+Shift+W doesn't work if Ctrl key is remapped. #11148

kasajian opened this issue Sep 5, 2021 · 6 comments
Assignees
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@kasajian
Copy link

kasajian commented Sep 5, 2021

Windows Terminal version (or Windows build number)

1.9.1942.0

Other Software

SharpKeys

Steps to reproduce

  1. Install SharpKeys (or some other similar app) that maps the Caps+Lock key to the Ctrl key
  2. open Windows Terminal, and create a tab or a pane.
  3. Attempt to close the tab or pane with Ctrl+Shift+W
    (using the Caps+Lock key instead of the Ctrl iey)

Expected Behavior

pane or tab should close

Actual Behavior

It doesn't close. But if you use the actual Ctrl key, it will work.

Please note that this is not SharpKeys related. That product simply helps construct the data that needs to be placed in the registry. The key mapping is a Windows feature.

@DHowett
Copy link
Member

DHowett commented Sep 7, 2021

@lhecker I suspect that this will be interesting to you!

@zadjii-msft zadjii-msft added Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Sep 7, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Sep 7, 2021
@lhecker lhecker self-assigned this Sep 7, 2021
@hsupu
Copy link

hsupu commented Dec 26, 2021

Same problem, Windows Terminal Version: 1.11.3471.0, remapping by SharpKeys (modify Registry)

I just failed to use Ctrl+Spacebar because remapped Ctrl to CapsLock. The original Ctrl works.

UPDATE: 1.12.10393.0 still not work

UPDATE: For laptop, remapped Ctrl works on external keyboard, neither original nor remapped Ctrl works on internal keyboard; for PC, it has only external keyboard so the remapped key works. I don't understand..

@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@manifestinteractive
Copy link

@kasajian thanks for posting, thought I was going crazy experiencing the same thing.

@jcrben
Copy link

jcrben commented Oct 14, 2023

I noticed that the remapped Caps Lock doesn't work right in this case on my work machine, but on my personal machine using PowerToys Keyboard Manager I'm not having the same issue.

Personal machine
Attaching the system info for my personal thinkpad t480 running Windows 10.
systeminfo.txt

Keyboard Manager right now is 0.70.1 0.74.1 - installed via winget - and my configuration is minimal:
image

Work machine
It's a Dell 5420 - not attaching more details. My work doesn't let me install PowerToys so I've tried AHK instead.

@kasajian
Copy link
Author

How can we get this to be fixed?

The developers who wrote this clearly aren't handling the Ctrl key the right way. It's fine. Mistakes happen. But why not fix it after you're told about it?

It's been like 3 years.

How do we get this thing attention?

@zadjii-msft
Copy link
Member

Anyone is welcome to investigate yourself what's up here. The code that handles keybindings is right here:

bool TermControl::_TryHandleKeyBinding(const WORD vkey, const WORD scanCode, ::Microsoft::Terminal::Core::ControlKeyStates modifiers) const

That's where I'd start with a breakpoint.

There's but a single 👍 on this issue, which means this probably isn't bubbling to the top of our list of priorities any time soon. But we'd be happy to review a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

7 participants