Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste Hangs Terminal (Right Mouse Click) #10157

Closed
thomashcampbell opened this issue May 23, 2021 · 12 comments
Closed

Paste Hangs Terminal (Right Mouse Click) #10157

thomashcampbell opened this issue May 23, 2021 · 12 comments
Labels
Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@thomashcampbell
Copy link

When copying and pasting I use the right mouse click. Highlight text, right mouse click. Then right mouse click to paste. If this is done too quickly it will hang the Windows Terminal to the point where it has to be killed

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 23, 2021
@skyline75489
Copy link
Collaborator

Are you trying to paste a string with lot of characters? What application are you using as the target of the paste operation? You'll need to give us more information for everyone to better understand the isseue.

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 24, 2021
@thomashcampbell
Copy link
Author

I could be one character or 100+. I've noticed it for a few weeks.

The only thing I've been able to notice is the speed with which I do it. If I highlight text, and then right click (copy), right click (paste) then it'll freeze.

I just tried it and couldn't make it do it but the terminal was fresh. Possibly has to do with the amount of time the terminal is running.

I'll attach more if I can figure out more conditions.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 25, 2021
@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels May 25, 2021
@devlie
Copy link
Member

devlie commented May 27, 2021

I'm reproing this frequently too.

  • No other app is involved. I'm just copying text from previous console output and trying to paste to the same console window.
  • It doesn't have to be a long text.

Would process dump at hanging state help? Watson bucket id e1924ce408e662d8acd60ed4a1a40008 (2077864584485797896)

@DHowett
Copy link
Member

DHowett commented May 27, 2021

Thanks for the watson ID!

@carlos-zamora this is interesting--

During TermnalPage's PasteFromClipboard handler, it's starting to interact with the Windows.DataTransfer APIs to get the clipboard content. During that handling, UIA is servicing a callback to get the selection information.

I thought that this would be easy, like "paste has a lock, and UIA wants the lock" but it doesn't seem to have the lock.

Let me look at the other threads quick ...

@DHowett
Copy link
Member

DHowett commented May 27, 2021

I can't find a single other thread that would be holding the lock. That's not great.

@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label May 31, 2021
@ghost
Copy link

ghost commented May 31, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@devlie
Copy link
Member

devlie commented Jun 1, 2021

Nudging Bot.

@ghost ghost added No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. and removed No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels Jun 1, 2021
@ghost
Copy link

ghost commented Jun 5, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost ghost closed this as completed Jun 9, 2021
@davclark
Copy link

davclark commented Dec 8, 2021

I'm still experiencing this issue on Windows 11

@ghost ghost removed the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Dec 8, 2021
@zadjii-msft
Copy link
Member

@davclark which version of the Terminal?

IIRC we made some changes recently to how we take the lock for accessibility reasons, which might be fixed in 1.12. Not sure thought - it could be something else entirely.

@thomashcampbell
Copy link
Author

I haven't had this happen in a long time. Considered it fixed. I'm on Windows 11 too.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 9, 2021
@davclark
Copy link

davclark commented Dec 9, 2021

I'm on 1.11.2921.0, running Ubuntu-20.04. I guess I'll try the preview and see if my problems go away?

Note that there may be some interaction with neovim (with set clipboard=unnamedplus, and a symbolic link to the win32yank.exe binary in /usr/local/bin). But once the problem starts occurring, it also happens with paste to a command prompt.

Since you mention accessibility, I also use sticky keys (which is a lifesaver for my RSI).

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

6 participants