Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in main when saving any setting with SUI #10103

Closed
PankajBhojwani opened this issue May 17, 2021 · 2 comments
Closed

Crash in main when saving any setting with SUI #10103

PankajBhojwani opened this issue May 17, 2021 · 2 comments
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Milestone
Terminal v1.9

Comments

@PankajBhojwani
Copy link
Contributor

Windows Terminal version (or Windows build number)

main

Other Software

N/A

Steps to reproduce

Note, this is separate from #10003.

Repro:

  1. Open SUI
  2. Click 'Save'
  3. Crash

Did some digging and it seems that we have an unhandled exception when trying to navigate back to the last selected item in the SUI (in MainPage::UpdateSettings, in the SettingsNav().SelectedItem(item) call on lines 139 and 152).

Expected Behavior

No crash

Actual Behavior

Crash
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 17, 2021
@PankajBhojwani PankajBhojwani added Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. labels May 17, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.9 milestone May 17, 2021
@zadjii-msft zadjii-msft added Severity-Blocking We won't ship a release like this! No-siree. Priority-0 Bugs that we consider release-blocking/recall-class (P0) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 17, 2021
@mpela81
Copy link
Contributor

mpela81 commented May 17, 2021

It seems to happen if you "Discard changes" as well.

@PankajBhojwani
Copy link
Contributor Author

This was resolved in #10124

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v1.9
Development

No branches or pull requests
3 participants
@mpela81 @zadjii-msft @PankajBhojwani