diff --git a/src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp b/src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp index e352214611f..efb75c06fda 100644 --- a/src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp +++ b/src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp @@ -43,20 +43,23 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation winrt::hstring LaunchViewModel::LaunchParametersCurrentValue() { const auto launchModeString = CurrentLaunchMode().as()->EnumName(); - const auto centerOnLaunchString = CenterOnLaunch() ? RS_(L"Globals_CenterOnLaunchOn") : RS_(L"Globals_CenterOnLaunchOff"); winrt::hstring result; + // Append the launch position part if (UseDefaultLaunchPosition()) { - result = fmt::format(L"{}, {}, {}", launchModeString, RS_(L"Globals_LaunchModeDefault/Content"), centerOnLaunchString); + result = fmt::format(L"{}, {}", launchModeString, RS_(L"Globals_LaunchModeDefault/Content")); } else { const std::wstring xPosString = isnan(InitialPosX()) ? RS_(L"Globals_LaunchModeDefault/Content").c_str() : std::to_wstring(gsl::narrow_cast(InitialPosX())); const std::wstring yPosString = isnan(InitialPosY()) ? RS_(L"Globals_LaunchModeDefault/Content").c_str() : std::to_wstring(gsl::narrow_cast(InitialPosY())); - result = fmt::format(L"{}, ({},{}), {}", launchModeString, xPosString, yPosString, centerOnLaunchString); + result = fmt::format(L"{}, ({},{})", launchModeString, xPosString, yPosString); } + + // Append the CenterOnLaunch part + result = CenterOnLaunch() ? winrt::hstring{ fmt::format(L"{}, {}", result, RS_(L"Globals_CenterOnLaunchCentered")) } : result; return result; } @@ -111,7 +114,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation { InitialPosX(NAN); InitialPosY(NAN); - _NotifyChanges(L"InitialPosX", L"InitialPosY"); } _NotifyChanges(L"UseDefaultLaunchPosition", L"LaunchParametersCurrentValue"); } diff --git a/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw index a9dacacd190..f264ca823fc 100644 --- a/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw +++ b/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw @@ -478,13 +478,9 @@ When enabled, this enables the launch of Terminal at machine startup. A description for what the "start on user login" setting does. Presented near "Globals_StartOnUserLogin.Header". - - On - The "On" value for the center on launch setting. - - - Off - The "Off" value for the center on launch setting. + + Centered + Shorthand, explanatory text displayed when the user has enabled the feature indicated by "Globals_CenterOnLaunch.Text". Center on launch