Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::variant on test overrides to allow other types #94

Open
arthuraraujo-msft opened this issue Feb 29, 2024 · 0 comments
Open

Use std::variant on test overrides to allow other types #94

arthuraraujo-msft opened this issue Feb 29, 2024 · 0 comments
Labels
nice to have This is not required, but would be nice to have
Milestone
Future

Comments

@arthuraraujo-msft
Copy link
Contributor 

          i'd add another field to the testoverride map containing the stored type and test that first.  I've seen issues where atoi (and maybe stoi) fails due to parsing and returns 0, and as such you end up returning "0" rather than "NaN".  Better still, maybe you can leverage std::variant (which I believe is type-safe) here?

Originally posted by @JeffMill in #90 (comment)
@arthuraraujo-msft arthuraraujo-msft added the nice to have This is not required, but would be nice to have label Feb 29, 2024
@arthuraraujo-msft arthuraraujo-msft added this to the Future milestone Feb 29, 2024
@arthuraraujo-msft arthuraraujo-msft mentioned this issue Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nice to have This is not required, but would be nice to have
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@arthuraraujo-msft